indilib: 2.1.6 -> 2.1.9; indi-3rdparty: 2.1.6.2 -> 2.1.9#472825
Merged
wegank merged 3 commits intoNixOS:masterfrom Feb 20, 2026
Merged
indilib: 2.1.6 -> 2.1.9; indi-3rdparty: 2.1.6.2 -> 2.1.9#472825wegank merged 3 commits intoNixOS:masterfrom
wegank merged 3 commits intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
I cannot test darwin, should I mark indilib broken on darwin or not run tests? |
Member
|
I am not sure if the tests are just not working on Darwin or if the package itself also doesn't work there. That would be my main concern how to handle this. |
Contributor
Author
|
I think it does in principle work on Darwin. They do have special handling for Mac OS in their cake files, so I suppose it would work on principle. Not sure why the tests fail though. |
Member
|
Then we should just disable the tests |
returntoreality
force-pushed
the
indi-update-2171
branch
from
b2ccc1f to
90985c3
Compare
Contributor
Author
|
I disabled the tests on darwin |
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
I think we need to disable some more things for darwin:
|
returntoreality
force-pushed
the
indi-update-2171
branch
from
90985c3 to
631c1c1
Compare
Contributor
Author
|
Not sure if the missing installcheck target is a actual problem, at least the install check seems to succeed regardless.
It seems they did not test building the subdirectories independently like they do for their debian packages and we do for the nixpkgs. The macro is defined in the base CMakeLists.txt. I wonder if we need the macro though, from my understanding of the cmake macro it should not do anything by default and only report errors. In this case it should just work if we remove the calls. I pushed a change that removes these lines from the respective CMakeLists.txt. |
Contributor
Author
|
@SuperSandro2000 could you try running your bot once more? |
This comment was marked as outdated.
This comment was marked as outdated.
returntoreality
force-pushed
the
indi-update-2171
branch
2 times, most recently
from
3ab883b to
c0fa231
Compare
Contributor
Author
|
I removed darwin from the platforms for the affected packages and marked them broken for darwin with a comment. Since they break now with autopatchelf I think this is not really solvable without access to a darwin system. |
Contributor
Author
|
@SuperSandro2000 could you check if darwin now only builds the working packages? |
|
returntoreality
force-pushed
the
indi-update-2171
branch
from
c0fa231 to
f726b65
Compare
Contributor
Author
|
@SuperSandro2000 thanks, I missed one it seems, fixed now (hopefully). |
nixpkgs-ci
bot
added
the
8.has: package (update)
returntoreality
force-pushed
the
indi-update-2171
branch
from
f726b65 to
ea84ccd
Compare
returntoreality
changed the title
Contributor
Author
|
I updated this PR to include the last update to 2.1.8. I setup nixpkgs-review-gha to test this on darwin and I can now cleanly build it on darwin. @SuperSandro2000 is this looking good now? |
returntoreality
force-pushed
the
indi-update-2171
branch
from
ea84ccd to
b7f2931
Compare
Contributor
Author
|
wegank
reviewed
Feb 5, 2026
pkgs/development/libraries/science/astronomy/indilib/indi-3rdparty.nix
Outdated
Show resolved
Hide resolved
returntoreality
force-pushed
the
indi-update-2171
branch
2 times, most recently
from
4bcc433 to
e856832
Compare
returntoreality
changed the title
Contributor
Author
|
I updated this PR with the latest indi-3rdparty release and I also tried to get darwin to build as many as possible (not sure if they will run) |
Contributor
Author
|
returntoreality
force-pushed
the
indi-update-2171
branch
from
e856832 to
c775b41
Compare
returntoreality
changed the title
Contributor
Author
|
returntoreality
force-pushed
the
indi-update-2171
branch
from
c775b41 to
48f8677
Compare
returntoreality
changed the title
The autopatchelfhook does not work with Mach-O binaries so remove it on darwin
returntoreality
force-pushed
the
indi-update-2171
branch
from
48f8677 to
4ec0338
Compare
Contributor
Author
|
Contributor
Author
|
@wegank @SuperSandro2000 could this be merged now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated indilib and the 3rdparty drivers to their latest version. They should be updated together
Corrected meta.platforms for darwin and disabled autoPatchElf for Darwin as it fails when hitting Mach-O files.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.