Skip to content

mop: 1.0.0 -> 0-unstable-2025-12-20#472797

Merged
gepbird merged 1 commit intoNixOS:masterfrom
DieracDelta:jr/mp
Dec 28, 2025
Merged

mop: 1.0.0 -> 0-unstable-2025-12-20#472797
gepbird merged 1 commit intoNixOS:masterfrom
DieracDelta:jr/mp

Conversation

@DieracDelta
Copy link
Member

@DieracDelta DieracDelta commented Dec 20, 2025 •
edited
Loading

Things done

Source is a 404--looks like the tag has been pulled. Not sure what rev it is so just pointed at HEAD of master.

Looks like the patches are no longer needed. Also seemed like it needed uniseg explicitly. I'm new to go packaging, so let me know if there's a more idiomatic way to do this.

Partially addresses #471645

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Dec 20, 2025
@DieracDelta
Copy link
Member Author

DieracDelta commented Dec 23, 2025

srcbot: Source verification passed

Step 1: Build Source (.src)

  • Command: nix build --print-build-logs --no-link --substituters '' --impure --expr '(import /home/jrestivo/dev/nixpkgs { system = "x86_64-linux"; config = { allowUnfree = true; }; }).mop.src'
  • Status: Exit Code: 0
Source Build Logs 
this derivation will be built:
  /nix/store/qqxpi6hd6xfdvhq3czf7skpgnnblkmfx-source.drv
building '/nix/store/qqxpi6hd6xfdvhq3czf7skpgnnblkmfx-source.drv'...
source> structuredAttrs is enabled
source> 
source> trying https://github.com/mop-tracker/mop/archive/64f37500a195d9c4e01eb3a97199b00515e9fd7a.tar.gz
source>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
source>                                  Dload  Upload   Total   Spent    Left  Speed
source>   0     0   0     0   0     0     0     0  --:--:-- --:--:-- --:--:--     0
source> 100 27564   0 27564   0     0 52166     0  --:--:-- --:--:-- --:--:-- 52166
source> unpacking source archive /build/download.tar.gz

Step 2: Build Package

  • Command: nix build --print-build-logs --no-link --impure --expr '(import /home/jrestivo/dev/nixpkgs { system = "x86_64-linux"; config = { allowUnfree = true; }; }).mop'
  • Status: Exit Code: 0
Package Build Logs 
this derivation will be built:
  /nix/store/44rsf7fjpbvcly6nrmwqgcmqx4j4r6gy-mop-unstable-2025-12-20.drv
building '/nix/store/44rsf7fjpbvcly6nrmwqgcmqx4j4r6gy-mop-unstable-2025-12-20.drv'...
mop-unstable> Running phase: unpackPhase
mop-unstable> unpacking source archive /nix/store/gyfc139y6lrq0s5jp22y9lld2nr32k6a-source
mop-unstable> source root is source
mop-unstable> Running phase: patchPhase
mop-unstable> Running phase: updateAutotoolsGnuConfigScriptsPhase
mop-unstable> Running phase: configurePhase
mop-unstable> Running phase: buildPhase
mop-unstable> Building subPackage .
mop-unstable> Building subPackage ./cmd/mop
mop-unstable> Running phase: checkPhase
mop-unstable> Running phase: installPhase
mop-unstable> Running phase: fixupPhase
mop-unstable> shrinking RPATHs of ELF executables and libraries in /nix/store/zijlv2xg3h3qfvb04669rjrrj27x0h1a-mop-unstable-2025-12-20
mop-unstable> shrinking /nix/store/zijlv2xg3h3qfvb04669rjrrj27x0h1a-mop-unstable-2025-12-20/bin/mop
mop-unstable> checking for references to /build/ in /nix/store/zijlv2xg3h3qfvb04669rjrrj27x0h1a-mop-unstable-2025-12-20...
mop-unstable> patching script interpreter paths in /nix/store/zijlv2xg3h3qfvb04669rjrrj27x0h1a-mop-unstable-2025-12-20
mop-unstable> stripping (with command strip and flags -S -p) in  /nix/store/zijlv2xg3h3qfvb04669rjrrj27x0h1a-mop-unstable-2025-12-20/bin

gepbird
gepbird previously requested changes Dec 27, 2025
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating the vendor hash, it fails to build for me:

mop> Building subPackage ./cmd/mop                                                                                                                                                                                 
mop> # golang.org/x/sys/unix                                                                                                                                                                                       
mop> vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)                                                                                  
mop> vendor/golang.org/x/sys/unix/syscall_linux.go:2255:9: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
mop> vendor/golang.org/x/sys/unix/syscall_unix.go:118:7: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
mop> vendor/golang.org/x/sys/unix/sysvshm_unix.go:33:7: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Dec 27, 2025
@DieracDelta
Copy link
Member Author

DieracDelta commented Dec 27, 2025

srcbot: Source verification passed

Step 1: Build Source (.src)

  • Command: nix build --print-build-logs --no-link --substituters '' --impure --expr '(import /home/jrestivo/dev/nixpkgs { system = "x86_64-linux"; config = { allowUnfree = true; }; }).mop.src'
  • Status: Exit Code: 0
Source Build Logs 
this derivation will be built:
  /nix/store/qqxpi6hd6xfdvhq3czf7skpgnnblkmfx-source.drv
building '/nix/store/qqxpi6hd6xfdvhq3czf7skpgnnblkmfx-source.drv'...
source> structuredAttrs is enabled
source> 
source> trying https://github.com/mop-tracker/mop/archive/64f37500a195d9c4e01eb3a97199b00515e9fd7a.tar.gz
source>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
source>                                  Dload  Upload   Total   Spent    Left  Speed
source>   0     0   0     0   0     0     0     0  --:--:-- --:--:-- --:--:--     0
source> 100 27564   0 27564   0     0 57494     0  --:--:-- --:--:-- --:--:-- 57494
source> unpacking source archive /build/download.tar.gz

Step 2: Build goModules (.goModules)

  • Command: nix build --print-build-logs --no-link --substituters '' --impure --expr '(import /home/jrestivo/dev/nixpkgs { system = "x86_64-linux"; config = { allowUnfree = true; }; }).mop.goModules'
  • Status: Exit Code: 0
goModules Build Logs 
this derivation will be built:
  /nix/store/xq1xi9p1xdc4p6vh93rzis101d7j7n6z-mop-0-unstable-2025-12-20-go-modules.drv
building '/nix/store/xq1xi9p1xdc4p6vh93rzis101d7j7n6z-mop-0-unstable-2025-12-20-go-modules.drv'...
mop> Running phase: unpackPhase
mop> unpacking source archive /nix/store/gyfc139y6lrq0s5jp22y9lld2nr32k6a-source
mop> source root is source
mop> Running phase: patchPhase
mop> Running phase: updateAutotoolsGnuConfigScriptsPhase
mop> Running phase: configurePhase
mop> Running phase: buildPhase
mop> go: downloading github.com/nsf/termbox-go v1.1.1
mop> go: downloading github.com/eiannone/keyboard v0.0.0-20200508000154-caf4b762e807
mop> go: downloading github.com/Knetic/govaluate v3.0.0+incompatible
mop> go: downloading golang.org/x/sys v0.1.0
mop> go: downloading github.com/mattn/go-runewidth v0.0.13
mop> go: downloading github.com/rivo/uniseg v0.2.0
mop> Running phase: installPhase

Step 3: Build Package

  • Command: nix build --print-build-logs --no-link --impure --expr '(import /home/jrestivo/dev/nixpkgs { system = "x86_64-linux"; config = { allowUnfree = true; }; }).mop'
  • Status: Exit Code: 0
Package Build Logs 
this derivation will be built:
  /nix/store/bn1546ybcf82dy31a6qzy11mhmsz5hnb-mop-0-unstable-2025-12-20.drv
building '/nix/store/bn1546ybcf82dy31a6qzy11mhmsz5hnb-mop-0-unstable-2025-12-20.drv'...
mop> Running phase: unpackPhase
mop> unpacking source archive /nix/store/gyfc139y6lrq0s5jp22y9lld2nr32k6a-source
mop> source root is source
mop> Running phase: patchPhase
mop> Running phase: updateAutotoolsGnuConfigScriptsPhase
mop> Running phase: configurePhase
mop> Running phase: buildPhase
mop> Building subPackage .
mop> Building subPackage ./cmd/mop
mop> Running phase: checkPhase
mop> Running phase: installPhase
mop> Running phase: fixupPhase
mop> shrinking RPATHs of ELF executables and libraries in /nix/store/k5f2wv58dy13qq1dhfhi8azvrjhzqx9f-mop-0-unstable-2025-12-20
mop> shrinking /nix/store/k5f2wv58dy13qq1dhfhi8azvrjhzqx9f-mop-0-unstable-2025-12-20/bin/mop
mop> checking for references to /build/ in /nix/store/k5f2wv58dy13qq1dhfhi8azvrjhzqx9f-mop-0-unstable-2025-12-20...
mop> patching script interpreter paths in /nix/store/k5f2wv58dy13qq1dhfhi8azvrjhzqx9f-mop-0-unstable-2025-12-20
mop> stripping (with command strip and flags -S -p) in  /nix/store/k5f2wv58dy13qq1dhfhi8azvrjhzqx9f-mop-0-unstable-2025-12-20/bin

@gepbird gepbird changed the title mop: 1.0.0 -> unstable-2025-12-20 mop: 1.0.0 -> 0-unstable-2025-12-20 Dec 28, 2025
gepbird
gepbird reviewed Dec 28, 2025
View reviewed changes
@gepbird gepbird self-requested a review December 28, 2025 08:54
gepbird
gepbird approved these changes Dec 28, 2025
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mop.src, mop.goModules and mop rebuild fine, diff looks good.

@gepbird gepbird added this pull request to the merge queue Dec 28, 2025
Merged via the queue into NixOS:master with commit 3dab067 Dec 28, 2025
39 of 41 checks passed
@DieracDelta
Copy link
Member Author

DieracDelta commented Dec 28, 2025

srcbot: Full Evaluation Results

1/1 packages passed (full results)

@DieracDelta
Copy link
Member Author

DieracDelta commented Dec 28, 2025

srcbot: Full Evaluation Results

1/1 packages passed (full results)

@DieracDelta
Copy link
Member Author

DieracDelta commented Dec 29, 2025

srcbot: Full Evaluation Results for PR #472797

Status: 1/1 packages passed, 0 failed

1 packages passed
Package Steps Built
mop src, goModules, package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gepbird gepbird gepbird approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DieracDelta @gepbird