Skip to content

seahorse: fix build with gpgme 2.0+#472315

Merged
jtojnar merged 1 commit intoNixOS:staging-nextfrom
ghpzin:pr-seahorse-fix-build-with-gpgme2
Dec 19, 2025
Merged

seahorse: fix build with gpgme 2.0+#472315
jtojnar merged 1 commit intoNixOS:staging-nextfrom
ghpzin:pr-seahorse-fix-build-with-gpgme2

Conversation

@ghpzin
Copy link
Contributor

@ghpzin ghpzin commented Dec 19, 2025

Upstream issue:
https://gitlab.gnome.org/GNOME/seahorse/-/issues/410

Fixes build failure:

../pgp/seahorse-gpgme.c: In function 'on_gpgme_event':
../pgp/seahorse-gpgme.c:487:14: error: 'GPGME_EVENT_NEXT_TRUSTITEM'
undeclared (first use in this function);
did you mean 'GPGME_EVENT_NEXT_KEY'?
  487 |         case GPGME_EVENT_NEXT_TRUSTITEM:
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |              GPGME_EVENT_NEXT_KEY
...
ninja: build stopped: subcommand failed.

Related to gpgme update: #451898

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

- add patch from merged upstream MR:
https://gitlab.gnome.org/GNOME/seahorse/-/merge_requests/248
https://gitlab.gnome.org/GNOME/seahorse/-/commit/aa68522cc696fa491ccfdff735b77bcf113168d0

Upstream issue:
https://gitlab.gnome.org/GNOME/seahorse/-/issues/410

Fixes build failure:
```
../pgp/seahorse-gpgme.c: In function 'on_gpgme_event':
../pgp/seahorse-gpgme.c:487:14: error: 'GPGME_EVENT_NEXT_TRUSTITEM'
undeclared (first use in this function);
did you mean 'GPGME_EVENT_NEXT_KEY'?
  487 |         case GPGME_EVENT_NEXT_TRUSTITEM:
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |              GPGME_EVENT_NEXT_KEY
...
ninja: build stopped: subcommand failed.
```
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 19, 2025
@ghpzin
Copy link
Contributor Author

ghpzin commented Dec 19, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 472315
Commit: 4be7ea5b2ff3f61cf94575c66db04f9ed1862b63


x86_64-linux

✅ 1 package built:
  • seahorse

@ghpzin ghpzin marked this pull request as ready for review December 19, 2025 09:28
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, thanks.

@jtojnar jtojnar added this pull request to the merge queue Dec 19, 2025
Merged via the queue into NixOS:staging-next with commit a572397 Dec 19, 2025
32 of 35 checks passed
@ghpzin ghpzin deleted the pr-seahorse-fix-build-with-gpgme2 branch December 19, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants