Skip to content

arrow-cpp: fix arrow-azurefs-test#472089

Merged
K900 merged 1 commit intoNixOS:staging-nextfrom
ghpzin:pr-arrow-cpp-fix
Dec 19, 2025
Merged

arrow-cpp: fix arrow-azurefs-test#472089
K900 merged 1 commit intoNixOS:staging-nextfrom
ghpzin:pr-arrow-cpp-fix

Conversation

@ghpzin
Copy link
Contributor

@ghpzin ghpzin commented Dec 18, 2025

  • add azurite to nativeInstallCheckInputs with enableAzure

Fixes run of arrow-azurefs-test:

[----------] 6 tests from TestAzureFileSystemOnAllEnvs/0, where
TypeParam = arrow::fs::TestingScenario<arrow::fs::AzuriteEnv,false>
[ RUN      ] TestAzureFileSystemOnAllEnvs/0.DetectHierarchicalNamespace
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:901: Failure
Value of: _st.ok()
  Actual: false
Expected: true
'_error_or_value58.status()' failed with IOError: Failed to find 'azurite' in PATH
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:174  self->server_process_->SetExecutable("azurite")
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:108  AzureEnvClass::Make()
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:892  GetAzureEnv()

WARNING: Logging before InitGoogleLogging() is written to STDERR
F20251218 15:54:18.988654 140737274596864 result.cc:27] ValueOrDie
called on an error: IOError: Failed to find 'azurite' in PATH
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:174  self->server_process_->SetExecutable("azurite")
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:108  AzureEnvClass::Make()
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:892  GetAzureEnv()
*** Check failure stack trace: ***
/build/source/cpp/build/src/arrow/filesystem
...
The following tests FAILED:
         76 - arrow-azurefs-test (Failed)                       arrow-tests filesystem unittest
Errors while running CTest

Probably related to addition of enableAzure in #469433

Tested build of both default (enableAzure = true) and:

nix-build --expr 'with import ./. {}; arrow-cpp.override { enableAzure = false; }'

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

- add `azurite` to `nativeInstallCheckInputs` with `enableAzure`

Fixes run of `arrow-azurefs-test`:
```
[----------] 6 tests from TestAzureFileSystemOnAllEnvs/0, where
TypeParam = arrow::fs::TestingScenario<arrow::fs::AzuriteEnv,false>
[ RUN      ] TestAzureFileSystemOnAllEnvs/0.DetectHierarchicalNamespace
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:901: Failure
Value of: _st.ok()
  Actual: false
Expected: true
'_error_or_value58.status()' failed with IOError: Failed to find 'azurite' in PATH
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:174  self->server_process_->SetExecutable("azurite")
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:108  AzureEnvClass::Make()
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:892  GetAzureEnv()

WARNING: Logging before InitGoogleLogging() is written to STDERR
F20251218 15:54:18.988654 140737274596864 result.cc:27] ValueOrDie
called on an error: IOError: Failed to find 'azurite' in PATH
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:174  self->server_process_->SetExecutable("azurite")
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:108  AzureEnvClass::Make()
/build/source/cpp/src/arrow/filesystem/azurefs_test.cc:892  GetAzureEnv()
*** Check failure stack trace: ***
/build/source/cpp/build/src/arrow/filesystem
...
The following tests FAILED:
         76 - arrow-azurefs-test (Failed)                       arrow-tests filesystem unittest
Errors while running CTest
```
@ghpzin

This comment was marked as resolved.

@ghpzin ghpzin closed this Dec 18, 2025
@ghpzin ghpzin reopened this Dec 18, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. labels Dec 18, 2025
Copy link
Contributor

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, I sometimes forget that these test dependencies exist it seems...

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Dec 18, 2025
@ghpzin ghpzin marked this pull request as ready for review December 18, 2025 20:16
@ghpzin
Copy link
Contributor Author

ghpzin commented Dec 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 472089 --package arrow-cpp
Commit: cecb1a945d465490fec92d76a2ff5fcddaa014b1


x86_64-linux

✅ 1 package built:
  • arrow-cpp

Just to show that it indeed builds.
ofborg somehow failed on uvloop test:
https://logs.ofborg.org/?key=nixos/nixpkgs.472089&attempt_id=2c8c0bd3-577a-43b9-b8ab-baa6ae087342


And failed on uvloop test again:
https://logs.ofborg.org/?attempt_id=92d14071-bafc-4aae-ae7e-45261878d003&key=nixos%2Fnixpkgs.472089

log
FAILED tests/test_process.py::TestAsyncio_AIO_Process::test_cancel_post_init - AssertionError: unexpected calls to loop.call_exception_handler()
= 1 failed, 414 passed, 32 skipped, 6 deselected, 3 warnings in 88.02s (0:01:28) =
error: Cannot build '/nix/store/3n585ynwgmgmgysmsrrxbiv3r2d93bps-python3.13-uvloop-0.22.0.drv'.
     Reason: builder failed with exit code 1.
     Output paths:
       /nix/store/bl8hl9j4jmkrg03dj68yrsgirdvjr3wg-python3.13-uvloop-0.22.0
       /nix/store/cymnz7v8l4khb7cbzjv0kacf86by422h-python3.13-uvloop-0.22.0-dist
     Last 25 log lines:
     >     self._callTearDown()
     >     ~~~~~~~~~~~~~~~~~~^^
     >   File "/nix/store/qzc04a3npl70cyyy6flnnrb2ig3kayxm-python3-3.13.11/lib/python3.13/unittest/case.py", line 611, in _callTearDown
     >     self.tearDown()
     >     ~~~~~~~~~~~~~^^
     >   File "/nix/store/bl8hl9j4jmkrg03dj68yrsgirdvjr3wg-python3.13-uvloop-0.22.0/lib/python3.13/site-packages/uvloop/_testbase.py", line 327, in tearDown
     >     super().tearDown()
     >     ~~~~~~~~~~~~~~~~^^
     >   File "/nix/store/bl8hl9j4jmkrg03dj68yrsgirdvjr3wg-python3.13-uvloop-0.22.0/lib/python3.13/site-packages/uvloop/_testbase.py", line 106, in tearDown
     >     self.fail('unexpected calls to loop.call_exception_handler()')
     >     ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     >   File "/nix/store/qzc04a3npl70cyyy6flnnrb2ig3kayxm-python3-3.13.11/lib/python3.13/unittest/case.py", line 732, in fail
     >     raise self.failureException(msg)
     > AssertionError: unexpected calls to loop.call_exception_handler()
     > =============================== warnings summary ===============================
     > tests/test_executors.py::TestUVExecutors::test_executors_process_pool_01
     > tests/test_executors.py::TestAIOExecutors::test_executors_process_pool_01
     > tests/test_regr1.py::TestIssue39Regr::test_issue39_regression
     >   /nix/store/qzc04a3npl70cyyy6flnnrb2ig3kayxm-python3-3.13.11/lib/python3.13/multiprocessing/popen_fork.py:67: DeprecationWarning: This process (pid=256) is multi-threaded, use of fork() may lead to deadlocks in the child.
     >     self.pid = os.fork()
     >
     > -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
     > =========================== short test summary info ============================
     > FAILED tests/test_process.py::TestAsyncio_AIO_Process::test_cancel_post_init - AssertionError: unexpected calls to loop.call_exception_handler()
     > = 1 failed, 414 passed, 32 skipped, 6 deselected, 3 warnings in 88.02s (0:01:28) =
     For full logs, run:
       nix log /nix/store/3n585ynwgmgmgysmsrrxbiv3r2d93bps-python3.13-uvloop-0.22.0.drv

@ghpzin ghpzin marked this pull request as draft December 18, 2025 20:26
@ghpzin ghpzin closed this Dec 18, 2025
@ghpzin ghpzin reopened this Dec 18, 2025
@ghpzin ghpzin marked this pull request as ready for review December 18, 2025 20:54
@nixpkgs-ci nixpkgs-ci bot requested review from cpcloud, tobim and veprbl December 18, 2025 21:04
@K900 K900 added this pull request to the merge queue Dec 19, 2025
Merged via the queue into NixOS:staging-next with commit c3f33f4 Dec 19, 2025
81 of 85 checks passed
@ghpzin ghpzin deleted the pr-arrow-cpp-fix branch December 19, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants