update picard 1.2->1.3, initial pkg for python-libdiscid#4718
Conversation
pkgs/top-level/python-packages.nix
Outdated
Member
There was a problem hiding this comment.
fetchurl isn't imported here. You should call it as pkgs.fetchurl.
Author
|
Its good you noticed that, when I cherry-picked from my working branch to master I didn't notice that libdiscid had already been packaged, so its moot anyhow. |
Member
|
Could you update the commit title to reflect that? |
Author
|
travis: |
Member
|
That happens when it tries to recompile qt :) Since the patch doesn't touch anything but picard, I can take your word that it works and merge it. |
madjar
added a commit
that referenced
this pull request
Nov 4, 2014
update picard 1.2->1.3, initial pkg for python-libdiscid
This was referenced Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.