Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
Yarny0
approved these changes
Dec 18, 2025
Contributor
Yarny0
left a comment
Yarny0
left a comment
There was a problem hiding this comment.
Review per https://github.com/NixOS/nixpkgs/tree/1306659b587dc277866c7b69eb97e5f07864d8c4/pkgs#package-updates
Reviewed points
Everything below tested on x86_64-linux, after cherry-picking #470602, #466746 and the pull request at hand onto current nixos-unstable:
- package name fits guidelines
- package version fits guidelines
- package builds on
x86_64-linux - executables tested on ARCHITECTURE
- any change of upstream are verified (none)
- the motives for any special packaging choices are documented (none)
- all depending packages build
- patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed (none)
- patches that are remotely available are fetched rather than vendored (none)
More:
- license still matches upstream
-
xterm.testsbuild/pass - quick test: xterm works fine, respects color settings in
.Xresources
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2699 |
nixpkgs-ci
bot
added
12.approvals: 1
Yarny0
approved these changes
Dec 24, 2025
Contributor
Yarny0
left a comment
Yarny0
left a comment
There was a problem hiding this comment.
Review per https://github.com/NixOS/nixpkgs/tree/a6531044f6d0bef691ea18d4d4ce44d0daa6e816/pkgs#package-updates
Reviewed points
Everything below tested on x86_64-linux, after cherry-picking #470602, #466746 and the commit of the pull request at hand onto current nixos-unstable:
- package name fits guidelines
- package version fits guidelines
- package builds on
x86_64-linux - executables tested on ARCHITECTURE
- any change of upstream are verified (none)
- the motives for any special packaging choices are documented (none)
- all depending packages build
- patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed (none)
- patches that are remotely available are fetched rather than vendored (none)
More:
- license still matches upstream
-
xterm.testsbuild/pass -
xtermstarts and shows window -
xtermrespects color settings in.Xresources -
xterm -n my-titleuses proper window name -
xterm python3starts Python in terminal
I reaffirm my approval.
fabianhjr
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.