nixVersions.nix_2_33: init by philiptaron · Pull Request #471463 · NixOS/nixpkgs

philiptaron · 2025-12-16T21:32:07Z

See https://discourse.nixos.org/t/nix-2-33-0-released/73109

Marking as draft until I review the upstream Nix packaging changes around S3.

Things done

Add a 👍 reaction to pull requests you find important.

philiptaron · 2025-12-17T01:39:42Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 471463 --additional-package nixVersions.latest.tests
Commit: 04c4952f7c082e7d34986e848b686c9dd1da4e32

`x86_64-linux`

✅ 14 packages built:

nixVersions.latest (nixVersions.nix_2_33)
nixVersions.latest.dev (nixVersions.nix_2_33.dev)
nixVersions.latest.doc (nixVersions.nix_2_33.doc)
nixVersions.latest.man (nixVersions.nix_2_33.man)
nixVersions.latest.tests.misc
nixVersions.latest.tests.nixi686
nixVersions.latest.tests.nixi686.dev
nixVersions.latest.tests.nixi686.doc
nixVersions.latest.tests.nixi686.man
nixVersions.latest.tests.nixpkgs-lib
nixVersions.latest.tests.pkg-config
nixVersions.latest.tests.simpleUefiSystemdBoot
nixVersions.latest.tests.srcVersion
nixVersions.latest.tests.upgrade

nixos-discourse · 2025-12-17T01:40:35Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-2-33-0-released/73109/3

xokdvium · 2025-12-17T02:13:46Z

We should wait for 2.33.1 to get NixOS/nix#14799. Otherwise it will get pretty messy.

philiptaron · 2025-12-17T04:31:28Z

Drafting until then. Thanks Sergei @xokdvium

lovesegfault · 2025-12-17T04:32:04Z

pkgs/tools/package-management/nix/default.nix

+      nixComponents_2_33 = nixDependencies.callPackage ./modular/packages.nix rec {
+        version = "2.33.0";
+        inherit (self.nix_2_32.meta) maintainers teams;
+        otherSplices = generateSplicesForNixComponents "nixComponents_2_33";
+        src = fetchFromGitHub {
+          owner = "NixOS";
+          repo = "nix";
+          tag = version;
+          hash = "sha256-aVwmNDnTOYZZQbTy++rYS0NOGEu9Zwljg3+TXJmw4TE=";
+        };
+      };
+
+      nix_2_33 = addTests "nix_2_33" self.nixComponents_2_33.nix-everything;


i think something else should've changed because we no longer depend on the aws-sdk.

I did that a while back with a .git version bump.

philiptaron · 2026-01-07T22:00:06Z

Any progress on a 2.33.1 @xokdvium and team? I see 2.31.3 was released a little bit ago; I'll package that up.

xokdvium · 2026-01-07T22:06:30Z

Yeah, the hydra jobsets just need a fresh rebuild before we can tag + upload.

xokdvium · 2026-01-15T20:32:52Z

@philiptaron, 2.33.1 is tagged and uploaded.

philiptaron · 2026-01-15T20:35:08Z

Thank you!

Ericson2314 · 2026-01-15T21:47:36Z

A bunch of CI failure I can't even read, so I assume they are spurious ones stemming from the issues that appear to be going on with GitHub right now.

philiptaron · 2026-01-15T22:06:37Z

I have the same suspicion. Thanks GitHub.

xokdvium · 2026-01-15T22:11:23Z

Eh, but the eval failure seems legitimate?

xokdvium · 2026-01-15T22:11:55Z

       error: function 'anonymous lambda' called with unexpected argument 'maintainers'
       at /nix/store/g4rffx2f8n9lgz7m2xwhfq8mj0w79879-source/pkgs/tools/package-management/nix/modular/packages.nix:1:1:
            1| {
             | ^
            2|   lib,

philiptaron · 2026-01-15T22:16:15Z

I didn't rebase on master 🤦🏻

nixpkgs-ci · 2026-01-16T00:54:52Z

Successfully created backport PR for release-25.11:

[Backport release-25.11] nixVersions.nix_2_33: init #480542

trofi · 2026-01-16T10:40:56Z

Looks like this update broke contentAddressedByDefault = true; systems again. Simple reproducer against nixosTests:

2.33.1 fails as:

$ nix build --no-link -f. nixosTests.boot.uefiUsb --arg config '{ contentAddressedByDefault = true; }'
evaluation warning: The user 'root' has multiple of the options
                    `initialHashedPassword`, `hashedPassword`, `initialPassword`, `password`
                    & `hashedPasswordFile` set to a non-null value.

                    If multiple of these password options are set at the same time then a
                    specific order of precedence is followed, which can lead to surprising
                    results. The order of precedence differs depending on whether the
                    {option}`users.mutableUsers` option is set.

                    If the option {option}`users.mutableUsers` is
                    `true`, then the order of precedence is as shown
                    below, where values on the left are overridden by values on the right:
                    {option}`initialHashedPassword` -> {option}`initialPassword` -> {option}`hashedPassword` -> {option}`password` -> {option}`hashedPasswordFile`

                    The values of these options are:
                    * users.users."root".hashedPassword: null
                    * users.users."root".hashedPasswordFile: "/09x4c5d9qvjikiv14lni976nbgm9p8briibh7xf7pj48n7721485"
                    * users.users."root".password: null
                    * users.users."root".initialHashedPassword: ""
                    * users.users."root".initialPassword: null
error:
       … while parsing derivation '/nix/store/c363hbhjag67d1a9qxc4jdqxpiynijpq-closure-info.drv'

       error: path '/1brwbcr7s8g31j7avczw6l8rk2imx9wybac58sz6vxxgjavw6dky/modprobe.conf' is not in the Nix store

2.32.5:

nix build --no-link -f. nixosTests.boot.uefiUsb --arg config '{ contentAddressedByDefault = true; }'
evaluation warning: The user 'root' has multiple of the options
                    `initialHashedPassword`, `hashedPassword`, `initialPassword`, `password`
                    & `hashedPasswordFile` set to a non-null value.

                    If multiple of these password options are set at the same time then a
                    specific order of precedence is followed, which can lead to surprising
                    results. The order of precedence differs depending on whether the
                    {option}`users.mutableUsers` option is set.

                    If the option {option}`users.mutableUsers` is
                    `true`, then the order of precedence is as shown
                    below, where values on the left are overridden by values on the right:
                    {option}`initialHashedPassword` -> {option}`initialPassword` -> {option}`hashedPassword` -> {option}`password` -> {option}`hashedPasswordFile`

                    The values of these options are:
                    * users.users."root".hashedPassword: null
                    * users.users."root".hashedPasswordFile: "/09x4c5d9qvjikiv14lni976nbgm9p8briibh7xf7pj48n7721485"
                    * users.users."root".password: null
                    * users.users."root".initialHashedPassword: ""
                    * users.users."root".initialPassword: null
[0/3168 built, 16/358/1480 copied (134.3/14819.9 MiB), 124.7/5988.7 MiB DL] fetching comonad-5.0.9-r1.cabal from https://cache.nixos.org

builds things as expected.

trofi · 2026-01-16T10:45:23Z

Filed upstream nix report as NixOS/nix#15003

philiptaron requested a review from lovesegfault December 16, 2025 21:32

nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Dec 16, 2025

philiptaron marked this pull request as ready for review December 17, 2025 01:29

nixpkgs-ci bot requested review from Ericson2314, Mic92, Radvendii, RaitoBezarius, edolstra, tomberek and xokdvium December 17, 2025 02:10

philiptaron marked this pull request as draft December 17, 2025 04:31

lovesegfault reviewed Dec 17, 2025

View reviewed changes

philiptaron force-pushed the nixVersions.nix_2_33 branch from 04c4952 to 86450ac Compare January 15, 2026 21:33

philiptaron marked this pull request as ready for review January 15, 2026 21:33

Ericson2314 approved these changes Jan 15, 2026

View reviewed changes

nixVersions.nix_2_33: init at 2.33.1

959699c

philiptaron force-pushed the nixVersions.nix_2_33 branch from 86450ac to 959699c Compare January 15, 2026 22:16

nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 15, 2026

nixpkgs-ci bot requested review from Artturin, Ericson2314, lovesegfault and roberth January 15, 2026 22:21

Ericson2314 added this pull request to the merge queue Jan 16, 2026

Ericson2314 added the backport release-25.11 Backport PR automatically label Jan 16, 2026

Merged via the queue into NixOS:master with commit 249e5cb Jan 16, 2026
48 of 52 checks passed

Ericson2314 deleted the nixVersions.nix_2_33 branch January 16, 2026 00:54

nixpkgs-ci bot mentioned this pull request Jan 16, 2026

[Backport release-25.11] nixVersions.nix_2_33: init #480542

Open

github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jan 16, 2026

trofi mentioned this pull request Jan 16, 2026

2.33.1 fails to build nixos system (regressed since 2.32.5) NixOS/nix#15003

Open

2 tasks

Uh oh!

Conversation

philiptaron commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

philiptaron commented Dec 17, 2025

nixpkgs-review result

x86_64-linux

Uh oh!

nixos-discourse commented Dec 17, 2025

Uh oh!

xokdvium commented Dec 17, 2025

Uh oh!

philiptaron commented Dec 17, 2025

Uh oh!

lovesegfault Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

xokdvium Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

philiptaron commented Jan 7, 2026

Uh oh!

xokdvium commented Jan 7, 2026

Uh oh!

xokdvium commented Jan 15, 2026

Uh oh!

philiptaron commented Jan 15, 2026

Uh oh!

Ericson2314 commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

philiptaron commented Jan 15, 2026

Uh oh!

xokdvium commented Jan 15, 2026

Uh oh!

xokdvium commented Jan 15, 2026

Uh oh!

philiptaron commented Jan 15, 2026

Uh oh!

Uh oh!

nixpkgs-ci bot commented Jan 16, 2026

Uh oh!

trofi commented Jan 16, 2026

Uh oh!

trofi commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

philiptaron commented Dec 16, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

Ericson2314 commented Jan 15, 2026 •

edited

Loading