A language security tool called Hammer is added

[sjmackenzie]

A patch needs to land on Hammer to make this compile, so in a few hours Travis will pass.

[sjmackenzie]

See #4694 for more details.

[sjmackenzie]

Patch has landed (UpstandingHackers/hammer#107), please kickstart Travis to recompile the PR.

[abiggerhammer]

That patch has landed. Thanks @sjmackenzie!

EDIT: derp, you already said that :) Still, thanks!

[sjmackenzie]

No thank you @abiggerhammer!

[abiggerhammer]

-git-export' should have r:sha256 hash 1ay790qi127crxncgsdi4qvai1s0ckq0yzzk19b1zvdlws4rvw93', instead has 1v8f2a6bgjgdkhbqz751bqjlwb9lmqn5x63xcskwcl2b9n36vqi9' cannot build derivation /nix/store/rgwxhv5p7x0zs5yjy8c364fpfj0i1ybc-hammer-1.0.0-rc3.drv': 1 dependencies couldn't be built`

The PR would change the hash, wouldn't it. facepalm

[sjmackenzie]

facepalmed

[sjmackenzie]

@Fuuzetsu or @iElectric please could you review the patch and merge if happy.

[domenkozar]

description is one line long, for longer descriptions use longDescription meta field

[sjmackenzie]

okay @iElectric please review

[domenkozar]

I'd prefer to use fetchurl and download https://github.com/UpstandingHackers/hammer/archive/v1.0.0-rc3.tar.gz

[sjmackenzie]

Not possible, as there was a patch to Hammer allowing it to correctly build on NixOS. That patch doesn't seem to be part of release v1.0.0-rc3.

[domenkozar]

That gives us two options:

1. download 1.0.0-rc3 release and apply the patch separately
2. change version of hammer to e7aa734

[sjmackenzie]

Hmm okay, never done a patch apply before. I'll need a bit of time to figure it out. We shouldn't require a Hammer version bump. That's up to Hammer's community to advance at their own rate.

[domenkozar]

Easier route is to change version = "e7aa734";

If you're going to apply a patch, make sure you copy it into nixpkgs hammer directory. Grep around for patches =

[sjmackenzie]

Okay I read too deeply into that, the old ways were surfacing...

[sjmackenzie]

All done.

[sjmackenzie]

Thanks!