[Backport release-25.11] jetbrains: pycharm/idea unified builds; deprecate writerside & aqua#471061
Conversation
There was a problem hiding this comment.
This report is automatically generated by the PR / Check / cherry-pick CI workflow.
Some of the commits in this PR require the author's and reviewer's attention.
If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.
Important
e7c64cc is not a cherry-pick, because: Too many changes to maintainer list that can't be easily cherry picked.. Please review this commit manually.
Hint: The full diffs are also available in the runner logs with slightly better highlighting.
I'd prefer to consider "syncing maintainers with master" to be a separate logical unit, so a separate commit. This way the actual backport commit will be an exact cherry-pick. |
0b2baba to
fae97d5
Compare
|
Sure, how about this? Edit: Actually I'm not sure what I did now is allowed?
I guess I would need to also chery-pick these commits properly, but I can't, there are too many conflicts: I added the |
…erside & aqua (cherry picked from commit 2843a9a)
fae97d5 to
a6614d1
Compare
MattSturgeon
left a comment
There was a problem hiding this comment.
Perfect, thanks.
Yeah, the point of the bot's review is to:
- Lint any issues with cherry-picks, i.e. missing the commit hash reference.
- Highlight any difference with the commit being cherry-picked, to aid manual review.
- Highlight any commits that aren't cherry-picked, so that they aren't glossed over in review.
This means reviewers can have confidence in commits the bot doesn't highlight, because they are clean cherry-picks of something already merged into master.
The things the bot does highlight aren't necessarily problems; they're just things that need manual review.
Backport for #466331
The automatic backport just failed due to some changes in the maintainer lists not being backported; I backported the maintainer lists from 25.11 in a seperate commit.