freecad: fix filebrowser crash on Gnome 49#470594
Open
srounce wants to merge 1 commit intoNixOS:masterfrom
Open
freecad: fix filebrowser crash on Gnome 49#470594srounce wants to merge 1 commit intoNixOS:masterfrom
srounce wants to merge 1 commit intoNixOS:masterfrom
Conversation
It seems the gtk3 schema paths aren't present in XDG_DATA_DIRS on Gnome 49 and thus attempts to open a gtk3 filebrowser will fail, causing the application to crash. This commit adds the gtk3 gsettings schemas to the XDG_DATA_DIRS env var for the app via the wrapper script. Fixes NixOS#467783
Contributor
|
Sorry, by bad, just add back wrapGAppsHook3 to nativeBuildInputs , add I faultly deleted wrapGAppsHook3 cause i think |
Member
|
I compiled this with nixpkgs-review but the wrapper does not mention GSETTINGS_SCHEMA_PATH: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the gtk3 schema paths aren't present in XDG_DATA_DIRS on Gnome 49 and thus attempts to open a gtk3 filebrowser will fail, causing the application to crash. This commit adds the gtk3 gsettings schemas to the XDG_DATA_DIRS env var for the app via the wrapper script.
Fixes #467783
Not sure if this would be better placed being added to wrapQtAppsHook as this issue seems to affect all Qt applications.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.