Skip to content

buildEnv: enable structuredAttrs #470402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SFrijters wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

buildEnv: enable structuredAttrs #470402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions pkgs/build-support/buildenv/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,30 +88,37 @@ lib.makeOverridable (
lib.flatten
(lib.remove null)
];

pkgs = builtins.toJSON chosenOutputs;
in
runCommand name
(
rec {
{
env = {
inherit
pkgs
extraPrefix
ignoreCollisions
checkCollisionContents
ignoreSingleFileOutputs
manifest
;
pathsToLinkJSON = builtins.toJSON pathsToLink;
extraPathsFrom = toString (lib.optional includeClosures (writeClosure pathsForClosure));
};
Comment on lines +97 to +108
Copy link
Contributor

@ShamrockLee ShamrockLee Dec 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From PR #432957's perspective, referencing from finalAttrs.env.ignoreCollisions is much less intuitive compared to finalAttrs.ignoreCollisions.

In addition, the custom override overrider is prone to be overridden by callPackage-provided <pkg>.override when defining a package, and should be replaced by <pkg>.overrideAttrs. Again, overriding env.ignoreCollisions is less intuitive than overriding ignoreCollisions.

Perl has powerful built-in JSON-parsing support, which we are using to parse chosenOutputs (currently stringified as the pkgs attribute). Why not parsing $NIX_ATTRS_JSON_FILE?

COI disclosure: I'm the author of competing PR:

inherit
manifest
ignoreCollisions
checkCollisionContents
ignoreSingleFileOutputs
passthru
meta
pathsToLink
extraPrefix
postBuild
nativeBuildInputs
buildInputs
;
pathsToLinkJSON = builtins.toJSON pathsToLink;
pkgs = builtins.toJSON chosenOutputs;
extraPathsFrom = lib.optional includeClosures (writeClosure pathsForClosure);
preferLocalBuild = true;
allowSubstitutes = false;
# XXX: The size is somewhat arbitrary
passAsFile = if builtins.stringLength pkgs >= 128 * 1024 then [ "pkgs" ] else [ ];
__structuredAttrs = true;
}
// lib.optionalAttrs (pname != null) {
inherit pname;
Expand Down
Loading