Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkgs/by-name/li/libcamera/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@

stdenv.mkDerivation rec {
pname = "libcamera";
version = "0.5.2";
version = "0.6.0";

src = fetchgit {
url = "https://git.libcamera.org/libcamera/libcamera.git";
rev = "v${version}";
hash = "sha256-nr1LmnedZMGBWLf2i5uw4E/OMeXObEKgjuO+PUx/GDY=";
hash = "sha256-zGcbzL1Q2hUaj/s9NjBlp7hVjmSFb0GF8CnCoDS82Tw=";
};

outputs = [
Expand Down Expand Up @@ -112,6 +112,7 @@ stdenv.mkDerivation rec {
"-Dv4l2=true"
(lib.mesonEnable "tracing" withTracing)
(lib.mesonEnable "qcam" withQcam)
"-Dlibunwind=disabled"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we do not want this? If so - that should be in a comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we were effectively doing before, the option was just made explicit now so we have to put this here instead of just compiling without libunwind.

Libunwind has been disabled the entire time we've been packaging libcamera, and I don't see any explanation of why that is, so I'd rather not comment with an uneducated guess here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libunwind is for debugging, so it seems reasonable to disable it. (I'd have used lib.mesonEnable but it's whatever.) Arguably it could depend on withTracing.

"-Dlc-compliance=disabled" # tries unconditionally to download gtest when enabled
# Avoid blanket -Werror to evade build failures on less
# tested compilers.
Expand Down
Loading