Skip to content

[Backport release-25.11] tree-sitter: fix pkgsStatic build#469985

Closed
nixpkgs-ci[bot] wants to merge 1 commit intorelease-25.11from
backport-443375-to-release-25.11
Closed

[Backport release-25.11] tree-sitter: fix pkgsStatic build#469985
nixpkgs-ci[bot] wants to merge 1 commit intorelease-25.11from
backport-443375-to-release-25.11

Conversation

@nixpkgs-ci
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Dec 11, 2025

Bot-based backport to release-25.11, triggered by a label in #443375.

Before merging, ensure that this backport is acceptable for the release.

Even as a non-committer, if you find that it is not acceptable, leave a comment.

Tip

If you maintain all packages touched by this pull request, and they are all located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this PR using the nixpkgs-merge-bot.

(cherry picked from commit 2b9bb8c)
@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 11, 2025
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 4.workflow: backport This targets a stable branch labels Dec 11, 2025
Copy link
Contributor

@Jayman2000 Jayman2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, ensure that this backport is acceptable for the release.

At the moment, the “Changes acceptable for releases” section of CONTRIBUTING.md says:

The release branches should generally only receive backwards-compatible changes, both for the Nix expressions and derivations.
Here are some examples of changes that are okay to backport:

  • ✔️ New packages, modules and functions
  • ✔️ Security fixes
  • ✔️ Package version updates
    • ✔️ Patch versions with fixes
    • ✔️ Minor versions with new functionality, but no breaking changes

This pull request appears to be a bug fix which means that it is acceptable for releases.

I tried building pkgsStatic.tree-sitter using 7e0818c (the tip of release-25.11 at the moment). As expected, it failed to build. I then tried building pkgsStatic.tree-sitter using the commit from this pull request. It built successfully which indicates that this pull request does successfully fix the bug that it’s trying to fix.

Additionally, I tried building tree-sitter using this pull request and running tree-sitter --help. It seemed to work fine. I was also able to build tree-sitter.tests successfully using this pull request.

That being said, the “Changes causing mass rebuilds” section of CONTRIBUTING.md says:

As a rule of thumb, if the number of rebuilds is 500 or more, consider targeting the staging branch instead of master; if the number is 1000 or more, the pull request causes a mass rebuild, and should target the staging branch.

This pull request targets the release-25.11 branch. The labels for this pull request indicate that this pull request causes 501–1,000 rebuilds which means that we’re definitely in the territory where we should consider targeting the staging-25.11 branch instead of the release-25.11 branch (we might even be in the territory where we must target the staging-25.11 branch since there might be exactly 1,000 rebuilds). Additionally, the description for the “10.rebuild-linux: 501-1000” label says “This PR causes many rebuilds on Linux and should normally target the staging branches.”

With that in mind, I’m going to close this pull request and create a new pull request that targets the staging-25.11 branch. It might technically be OK according to the rules to merge this pull request into the release-25.11 branch, but it’s probably better to be safe than sorry here. Besides, this pull request is a backport of another pull request that targeted the staging branch. Someone probably accidentally clicked “backport release-25.11” instead of “backport staging-25.11” when creating this pull request anyway.

EDIT: I just created the new pull request. It’s #496892.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants