Skip to content

python3Packages.smolagents: split pytest checks to passthru.tests #469544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ShamrockLee wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

python3Packages.smolagents: split pytest checks to passthru.tests #469544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions pkgs/development/python-modules/smolagents/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
wikipedia-api,
}:

buildPythonPackage rec {
(buildPythonPackage rec {
pname = "smolagents";
version = "1.21.3";
pyproject = true;
Expand Down Expand Up @@ -122,6 +122,11 @@ buildPythonPackage rec {
# ];
});

# Split install checks to `passthru.tests.pytest-check`
# as it depends on `optional-dependencies`,
# which contains huge stuff like the GUI library `python3Packages.gradio`.
doCheck = false;

nativeCheckInputs = [
ipython
pytest-datadir
Expand Down Expand Up @@ -179,4 +184,16 @@ buildPythonPackage rec {
license = lib.licenses.asl20;
maintainers = with lib.maintainers; [ fab ];
};
}
}).overrideAttrs
(
finalAttrs: previousAttrs: {
passthru = previousAttrs.passthru // {
tests = previousAttrs.passthru.tests or { } // {
pytest-check = finalAttrs.overrideAttrs {
# buildPythonPackage maps doCheck to doInstallCheck.
doInstallCheck = true;
};
};
};
}
)
Loading