hydra: remove entry from all-packages#468932
Merged
Mindavi merged 1 commit intoNixOS:masterfrom Dec 16, 2025
Merged
Conversation
The entry in `all-packages.nix` was left in while moving to `by-name` with a [reference to the docs]. This recommendation had [since changed] and this commit aligns the expression with the new recommendation. [reference to the docs]: NixOS#338097 (comment) [since changed]: NixOS@4664ae4
nixpkgs-ci
bot
requested review from
Conni2461,
Mindavi,
dasJ and
helsinki-Jo
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
Mindavi
reviewed
Dec 10, 2025
| }: | ||
|
|
||
| let | ||
| nix = nixVersions.nix_2_32; |
Contributor
There was a problem hiding this comment.
I wonder whether this changes wrt splicing. Otherwise LGTM.
Mindavi
approved these changes
Dec 10, 2025
Contributor
Mindavi
left a comment
Mindavi
left a comment
There was a problem hiding this comment.
Not too concerned about the splicing but let's check if possible.
Contributor
|
Thanks for taking care of this. |
nixpkgs-ci
bot
added
12.approvals: 1
Contributor
|
@ofborg eval Seems like postgresql had some issues starting, might be/have been an issue on master. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entry in
all-packages.nixwas left in while moving toby-namewith a reference to the docs. This recommendation had since changed and this commit aligns the expression with the new recommendation.cc. @Mindavi @dasJ @Conni2461 @helsinki-Jo (as maintainers)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.