influxdb2: fix hardcoded source path#468444
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Dec 10, 2025
Merged
Conversation
Aleksanaa
reviewed
Dec 6, 2025
| @@ -30,7 +30,7 @@ let | |||
| hash = "sha256-aC+GYMaxYKkY9GMaeRx22hQ3xi3kfWpaTLC9ajqOaAA="; | |||
| }; | |||
|
|
|||
| flux = rustPlatform.buildRustPackage { | |||
| flux = rustPlatform.buildRustPackage (finalAttrs: { | |||
Member
There was a problem hiding this comment.
Just found that flux in Nixpkgs is an unmaintained package. Dropping it...
Member
Author
There was a problem hiding this comment.
hmm maybe we could name this package libflux so it doesn't conflict with this flux package from 2013? I do see some examples like this like libffi or libutil though im not sure if that's a best practice
Member
There was a problem hiding this comment.
Yeah, having it as a standalone package would make maintenance much easier. For flux, even if it's dropped now, you can't take that name anytime soon. libflux would be fine.
Member
|
SFrijters
approved these changes
Dec 6, 2025
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Influxdb2 does not build with
fetchedSourceNameDefault = "full". Reproducible withThis PR fixes the hardcoded path in the same style as #468402.
A lingering thought is that it might be worthwhile exposing libflux as its own package so it's actually overridable.
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.