Skip to content

influxdb2: fix hardcoded source path#468444

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
DieracDelta:jr/fix_influxdb2
Dec 10, 2025
Merged

influxdb2: fix hardcoded source path#468444
Aleksanaa merged 1 commit intoNixOS:masterfrom
DieracDelta:jr/fix_influxdb2

Conversation

@DieracDelta
Copy link
Member

@DieracDelta DieracDelta commented Dec 6, 2025

Things done

Influxdb2 does not build with fetchedSourceNameDefault = "full". Reproducible with

nix build --impure --expr 'let nixpkgs = builtins.getFlake "github:NixOS/nixpkgs/4c25e2da4d3a847e5105e6660f266cf46f108f2e"; in
    let
      pkgs = import nixpkgs {
        localSystem = "x86_64-linux";
        config = {
          fetchedSourceNameDefault = "full";
        };
      };
    in
    pkgs.influxdb2
    ' --substituters ""

This PR fixes the hardcoded path in the same style as #468402.

A lingering thought is that it might be worthwhile exposing libflux as its own package so it's actually overridable.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@DieracDelta DieracDelta requested a review from SFrijters December 6, 2025 14:49
@@ -30,7 +30,7 @@ let
hash = "sha256-aC+GYMaxYKkY9GMaeRx22hQ3xi3kfWpaTLC9ajqOaAA=";
};

flux = rustPlatform.buildRustPackage {
flux = rustPlatform.buildRustPackage (finalAttrs: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found that flux in Nixpkgs is an unmaintained package. Dropping it...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay we cannot drop it 😅

Copy link
Member Author

@DieracDelta DieracDelta Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm maybe we could name this package libflux so it doesn't conflict with this flux package from 2013? I do see some examples like this like libffi or libutil though im not sure if that's a best practice

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, having it as a standalone package would make maintenance much easier. For flux, even if it's dropped now, you can't take that name anytime soon. libflux would be fine.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 6, 2025
@SFrijters
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 468444
Commit: 33d6b9fb51f1a3802b70d6d9b2dbd829b3e067db

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 6, 2025
@Aleksanaa Aleksanaa added this pull request to the merge queue Dec 10, 2025
Merged via the queue into NixOS:master with commit 712c419 Dec 10, 2025
37 of 39 checks passed
@DieracDelta DieracDelta mentioned this pull request Dec 18, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants