Conversation
|
This is an RC version, we are not shipping it. |
K900
left a comment
There was a problem hiding this comment.
Please wait until 1.6 stable.
|
Thanks for the feedback, I understand now that 1.5.84 is a release candidate. I noticed that I included a separate package update here (#468216). Should I keep this pr open for when 1.6 stable comes out (also removing the pastel update I left) or should I close it? Happy to do whichever you prefer. |
|
If the pastel update gets merged before this, it should just disappear from this PR because of how git merges work, or you can rebase on top of master. Also, this needs to target staging because of the rebuild count. We can keep this open though, 1.6 stable should hopefully be soon-ish. |
|
1.5.85 got released, https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/0a27618cd4f43017c8e2aa7b68172e64ba48eb23:
Looks like it won't be too long anymore. We can probably update this PR to see if there's any surprises. |
|
Wim said a few more weeks. |
I was curious so I made sure that the new update doesn't change anything. |
|
Stable 1.6 version released https://gitlab.freedesktop.org/pipewire/pipewire/-/releases/1.6.0 |
|
We'll have to get that into the next staging cycle. |
|
Closing in favor of #492490. |
Changelog: https://gitlab.freedesktop.org/pipewire/pipewire/-/releases/1.5.84
Things done
Updated finalAttrs.version from
1.4.9->1.5.84and the hashes accordingly,Renamed meson option
systemd->libsystemdto match upstream changes,Disabled meson option
bluez5-codec-ldac-dec(not previously enabled, requires separate library;libldac),Disabled meson option
bluez5-plc-spandsp(not previously enabled, however,spandspis in nixpkgs but wasn't used before),Disabled meson option
onnxruntime(not previously enabled)Tested with:
./result/bin/pipewire --version("Compiled with libpipewire 1.5.84 Linked with libpipewire 1.5.84")nix-build --attr pipewire.passthru.testspassed 23/24.The failing test
spa-benchmark-aec.testrequires sample files. Debian also skips this test (1.5.81). Should it be disabled in Nix as well?Built on platform:
Tested, as applicable:
passthru.tests.Ran
nixpkgs-reviewon this PR. See nixpkgs-review usage.Tested basic functionality of all binary files, usually in
./result/bin/.Nixpkgs Release Notes
NixOS Release Notes
Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.
Add a 👍 reaction to pull requests you find important.