Skip to content

clang-tools: fix C++ include paths not being passed to tools#468130

Closed
yshui wants to merge 1 commit intoNixOS:masterfrom
yshui:clang-tools-cxx
Closed

clang-tools: fix C++ include paths not being passed to tools#468130
yshui wants to merge 1 commit intoNixOS:masterfrom
yshui:clang-tools-cxx

Conversation

@yshui
Copy link
Contributor

@yshui yshui commented Dec 5, 2025

c++ standard library paths are passed to clang via -cxx-isystem, which is not handled by the wrapper script. therefore clangd just can't find c++ includes.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related labels Dec 5, 2025
@yshui
Copy link
Contributor Author

yshui commented Dec 7, 2025

cc @Mic92 @cmm

@gregorburger
Copy link

Thanks for the fix; this seems to be affecting 25.11 as well.

@yshui
Copy link
Contributor Author

yshui commented Dec 11, 2025

Caused by 76a8ffa i think

@SuperSandro2000 SuperSandro2000 added the backport release-25.11 Backport PR automatically label Dec 15, 2025
@rebmit
Copy link
Contributor

rebmit commented Dec 17, 2025

Is this a duplicate of #462747? That one has been merged, but hasn't reached unstable branch yet.

@GrahamDennis
Copy link
Contributor

I agree, I think the root cause here is that #462747 needs to land to master but for whatever reason targeted staging.

@yshui
Copy link
Contributor Author

yshui commented Dec 17, 2025

Oh, i didnt' know the existence of #462747 . but that approach looks wrong. now cxx include paths are added to CPATH too, which might cause conflicts

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 24, 2026
@yshui yshui closed this Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants