Skip to content

python3Packages.tiktoken: fix cross build#467796

Closed
DavHau wants to merge 1 commit intoNixOS:stagingfrom
DavHau:tiktoken
Closed

python3Packages.tiktoken: fix cross build#467796
DavHau wants to merge 1 commit intoNixOS:stagingfrom
DavHau:tiktoken

Conversation

@DavHau
Copy link
Member

@DavHau DavHau commented Dec 4, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Dec 4, 2025
@nixpkgs-ci nixpkgs-ci bot requested a review from happysalada December 4, 2025 10:27
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Dec 4, 2025
happysalada
happysalada approved these changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@happysalada happysalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, leaving open at least 24h just not to antagonize anyone that would want to review

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Dec 4, 2025
@DavHau
Copy link
Member Author

DavHau commented Dec 4, 2025

Not needed anymore if we merge this instead which fixes all setuptools-rust based packages: #467817
This deprecates the hook entirely and instead makes setuptools-rust just do the right setup by default.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Dec 4, 2025
@DavHau DavHau closed this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@happysalada happysalada happysalada approved these changes

@Artturin Artturin Artturin approved these changes

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DavHau @happysalada @Artturin