Skip to content

python3Packages.bcrypt: fix cross build#467741

Closed
DavHau wants to merge 1 commit intoNixOS:stagingfrom
DavHau:bcrypt
Closed

python3Packages.bcrypt: fix cross build#467741
DavHau wants to merge 1 commit intoNixOS:stagingfrom
DavHau:bcrypt

Conversation

@DavHau
Copy link
Member

@DavHau DavHau commented Dec 4, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@DavHau DavHau mentioned this pull request Dec 4, 2025
Merged
14 tasks
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Dec 4, 2025
@nixpkgs-ci nixpkgs-ci bot requested a review from dotlambda December 4, 2025 06:22
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Dec 4, 2025
dotlambda
dotlambda reviewed Dec 4, 2025
View reviewed changes
pkgs/development/python-modules/bcrypt/default.nix
nativeBuildInputs = [
setuptools
Copy link
Member

@dotlambda dotlambda Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be in build-system

Copy link
Member Author

@DavHau DavHau Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so if I may ask?

Copy link
Member Author

@DavHau DavHau Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@dotlambda dotlambda Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it's a build time Python dependency

@DavHau
Copy link
Member Author

DavHau commented Dec 4, 2025

superseded by #467817

@DavHau DavHau closed this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda left review comments

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DavHau @dotlambda