v4l-utils: make BPF support optional#467296
Merged
nixpkgs-ci[bot] merged 1 commit intoNixOS:stagingfrom Dec 3, 2025
Merged
Conversation
nixpkgs-ci
bot
added
the
2.status: merge-bot eligible
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
nixpkgs-ci
bot
added
the
12.approvals: 1
dotlambda
commented
Dec 3, 2025
| (lib.mesonOption "gconvsysdir" "${glibc.out}/lib/gconv") | ||
| ] | ||
| ++ lib.optionals (stdenv.hostPlatform != stdenv.buildPlatform) [ | ||
| # BPF support fail to cross compile, unable to find `linux/lirc.h` |
Member
Author
Yarny0
approved these changes
Dec 3, 2025
Contributor
Yarny0
left a comment
Yarny0
left a comment
There was a problem hiding this comment.
I tested on x86_64-linux, with withBPF=true and withBPF=false, after cherry-picking onto current nixos-unstable:
- The output of
v4l2-ctl --list-formats-ext -d /dev/video${NUMBER}seems alright. -
dvbv5-zap --adapter=${ADAPTER} --channel=channels.dvbv5 --pat --output=/tmp/output.ts ${CHANNEL_NAME}records some TV into the output file as expected (tested with dvb-t2 and dvb-s2). -
qv4l2starts up and looks nice (I haven't tested any hardware access with this program). -
dtv-scan-tablesbuilds (it uses${v4l-utils}/bin/dvb-format-convertduring the build). -
dvbv5-scan --get_frontend --nit ${dtv-scan-tables}/share/dvbv5/dvb-t/${SOME_TRANSPONDER_FILE}finds a lot of dvb-t channels, as it should. -
mpv av://v4l2:/dev/video${NUMBER}shows a webcam's video stream. -
mpv dvb://${CHANNEL}works (tested with dvb-s).
nixpkgs-ci
bot
added
12.approvals: 2
Contributor
|
@NixOS/nixpkgs-merge-bot merge |
Contributor
|
@Yarny0 wants to merge this PR. Requirements to merge this PR with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #419046 (review)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.