mdbook: 0.4.52 -> 0.5.1#467009
Merged
roberth merged 8 commits intoNixOS:staging-nixosfrom Dec 25, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 101-500
This was referenced Dec 2, 2025
nixpkgs-ci
bot
removed
the
2.status: merge-bot eligible
Apply patches to lix_2_93, lix_2_94, and git versions to support building documentation with mdbook 0.5. The patch is from upstream Lix commit 54df89f6, which maintains compatibility with both mdbook 0.4.x and 0.5.x. https://git.lix.systems/lix-project/lix/issues/1051
roberth
requested review from
9999years,
Frostman,
lf-,
matthiasbeyer and
philiptaron
philiptaron
previously approved these changes
Dec 16, 2025
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
It's kind of messy, but I think this works. Doing a build.
Contributor
|
We do need to target the |
nixpkgs-ci
bot
added
12.approvals: 1
Member
Author
Done.
The process for that is to take them from releases.nixos.org, where they haven't changed, so it would be a no-op. |
Contributor
|
Contributor
|
I don't care about nixVersions.git but the devenv failure looks concerning. |
philiptaron
dismissed
their stale review
Robert, mind checking out the build failures? I think we can land it after those are addressed.
nixpkgs-ci
bot
removed
12.approvals: 1
Apply the mdbook 0.5 support patch to devenv's bundled Nix 2.30.4. The patch is from upstream Nix commit 5cbd7856, which maintains compatibility with both mdbook 0.4.x and 0.5.x. The doc/manual/package.nix file is excluded as it doesn't exist in cachix's Nix fork. NixOS/nix#14628
Update to latest Nix master which includes mdbook 0.5 support merged in PR NixOS#14690. NixOS/nix#14690
Member
Author
|
Hey @philiptaron, Thanks for the ping.
Known to be maintenance-heavy and not required
Regressions from mdbook upgrade. That seems to cover them all. I'll add the remaining regression to the TODO. |
philiptaron
reviewed
Dec 17, 2025
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
Doing a build. Changes LGTM.
2 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
The upgrade tests are dumb, and I'm skipping them. |
philiptaron
approved these changes
Dec 18, 2025
Update helix documentation build for mdbook 0.5 compatibility.
Changes:
- Replace deprecated {{#previous}}/{{#next}} helpers with {{#if}} blocks
- Update link references from {{link}} to {{previous.link}}/{{next.link}}
- Escape HTML tags in command descriptions to prevent markdown parsing errors
- Fix book-html path in postInstall (../book-html instead of book-html)
The mdbook 0.5 release changed navigation helpers from block helpers to
simple objects, requiring template syntax updates in index.hbs.
Update engage documentation build for mdbook 0.5 compatibility. Changes: - Remove deprecated 'multilingual' field from book.toml - Update git-repository-icon from 'fa-git-square' to 'fab-square-git' The 'multilingual' field was removed in mdbook 0.5 as it was never used. The FontAwesome icon name changed from 'fa-git-square' (FA 4) to 'fab-square-git' (FA 5 brand icon) in the version bundled with mdbook 0.5.
nixpkgs-ci
bot
added
12.approvals: 1
philiptaron
approved these changes
Dec 18, 2025
This supports mdbook 0.5.
RaitoBezarius
approved these changes
Dec 22, 2025
Member
RaitoBezarius
left a comment
RaitoBezarius
left a comment
There was a problem hiding this comment.
On the Lix changes:
- tested stable and its docs
- tested cross on stable and its docs
nixpkgs-ci
bot
added
12.approvals: 2
13 tasks
Contributor
|
Merged
via the queue into
NixOS:staging-nixos
with commit Dec 25, 2025
8e38f10
31 of 33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
engagehelixevil-helixmdbook-cmdrunmigrate to mdbook 0.5 FauconFan/mdbook-cmdrun#23Alternatively,
mdbook_0_4could be added.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Context
Add a 👍 reaction to pull requests you find important.