dockerTools: use closureInfo to load hashes and closure sizes into the Nix DB#46592
dockerTools: use closureInfo to load hashes and closure sizes into the Nix DB#46592dingxiangfei2009 wants to merge 3 commits intoNixOS:masterfrom
Conversation
|
I just realized that |
|
@dingxiangfei2009 I think you could also have a look at #39716. |
|
@grahamc @nlewo When are we moving towards 2.0? Also, if this PR is going to break some build, can we have a statistics on how many users are affected? If the proportion is low, we can still move to 2.0 while the affected users can pin their Notice that |
|
I close this PR in favor of #49414. |
|
@dingxiangfei2009 If we consider we have to use Nix 2.0, I don't think these PRs will break any builds. But... maybe you have an example? :/ |
|
@nlewo That is what I was thinking. I do not have any statistics on other users of this function, but I do not see any builds being re-triggered by this change according to the CI here. I would guess that there are no builds to be broken at all. :P |
Motivation for this change
Since
closureInfois a good extension ofexportReferencesGraph, we can use it to bootstrap Nix DB with this and possibly eliminates the need to recompute the hashes.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)