Skip to content

[WIP] RFC #33#46530

Closed
oxij wants to merge 6 commits intoNixOS:masterfrom
oxij:lib/logging
Closed

[WIP] RFC #33#46530
oxij wants to merge 6 commits intoNixOS:masterfrom
oxij:lib/logging

Conversation

@oxij
Copy link
Member

@oxij oxij commented Sep 11, 2018

See NixOS/rfcs#33, ignore the first two patches.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 11, 2018
nix-instantiate --eval --strict -E 'with ((import ./lib).extend(self: super: { config = { configVersion = "16.03"; traceLevel = 0; }; })); showVal 1'
nix-instantiate --eval --strict -E 'with ((import ./lib).extend(self: super: { config = { configVersion = "16.03"; }; })); showVal 1
nix-instantiate --eval --strict -E 'with ((import ./lib).extend(self: super: { config = { configVersion = "17.03"; }; })); showVal 1
nix-instantiate --eval --strict -E 'with ((import ./lib).extend(self: super: { config = { configVersion = "18.03"; }; })); showVal 1
@Profpatsch
Copy link
Member

Tangential: I’d leave the stuff in debug.nix and make debug.nix depend on logging.nix. Debug statements should usually not stay in the code once it’s commited.

@oxij oxij changed the title RFC #33 [WIP] RFC #33 Oct 19, 2018
@mmahut
Copy link
Member

mmahut commented Aug 25, 2019

Are there any updates on this pull request, please?

@Profpatsch
Copy link
Member

@oxij Do you intend to finish this WIP?

@oxij
Copy link
Member Author

oxij commented Aug 27, 2019 via email

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@Profpatsch
Copy link
Member

@oxij still the case?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 9, 2020
@oxij
Copy link
Member Author

oxij commented Jun 11, 2020 via email

@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@ryantm ryantm marked this pull request as draft October 23, 2020 03:11
@stale
Copy link

stale bot commented Apr 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 26, 2021
@Aleksanaa Aleksanaa closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants