Skip to content

python3Packages.pycuda: add maintainer and clean up#465047

Open
ConnorBaker wants to merge 2 commits intoNixOS:masterfrom
ConnorBaker:fix/pycuda-cleanup
Open

python3Packages.pycuda: add maintainer and clean up#465047
ConnorBaker wants to merge 2 commits intoNixOS:masterfrom
ConnorBaker:fix/pycuda-cleanup

Conversation

@ConnorBaker
Copy link
Contributor

@ConnorBaker ConnorBaker commented Nov 25, 2025 •
edited
Loading

Important

This PR depends on #465329.

  • Add myself as a maintainer.
  • Removes dependency on cudatoolkit.
  • Fix calling convention in pkgs/top-level/python-packages.nix.
  • Adds tests.

pycuda is required for onnx-tensorrt releases prior to 10.14.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ConnorBaker ConnorBaker self-assigned this Nov 25, 2025
@ConnorBaker ConnorBaker added the 6.topic: cuda Parallel computing platform and API label Nov 25, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. and removed 6.topic: cuda Parallel computing platform and API labels Nov 25, 2025
@ConnorBaker ConnorBaker force-pushed the fix/pycuda-cleanup branch 3 times, most recently from 9c3c336 to 127a0f9 Compare November 26, 2025 13:31
@ConnorBaker ConnorBaker marked this pull request as ready for review November 26, 2025 13:36
@ConnorBaker
Copy link
Contributor Author

ConnorBaker commented Nov 26, 2025

nixpkgs-reviews are in progress.

@nixpkgs-ci nixpkgs-ci bot requested a review from natsukium November 26, 2025 13:48
@ConnorBaker ConnorBaker changed the title python3Packages.pycuda: 2025.1.2 -> 2025.1.2-unstable-2025-10-12 python3Packages.pycuda: package cleanup Nov 26, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: cuda Parallel computing platform and API and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Nov 26, 2025
@ConnorBaker ConnorBaker changed the title python3Packages.pycuda: package cleanup Wrap NVCC for use outside mkDerivation and clean up pycuda expression Nov 26, 2025
@ConnorBaker
cudaPackages.cuda_nvcc: wrap binary so NVCC can always find compiler
029a8fc 
Signed-off-by: Connor Baker <ConnorBaker01@gmail.com>
@ConnorBaker
python3Packages.pycuda: add maintainer and clean up
e97018c 
Signed-off-by: Connor Baker <ConnorBaker01@gmail.com>
@ConnorBaker ConnorBaker mentioned this pull request Nov 26, 2025
Merged
13 tasks
@ConnorBaker ConnorBaker changed the title Wrap NVCC for use outside mkDerivation and clean up pycuda expression python3Packages.pycuda: add maintainer and clean up Nov 26, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 1, 2025
GaetanLepage
GaetanLepage reviewed Dec 3, 2025
View reviewed changes
pkgs/development/cuda-modules/packages/cuda_nvcc.nix

nixLog "wrapping nvcc to add backendStdenv.cc to its PATH"
mv "''${!outputBin:?}/bin/nvcc" "''${!outputBin:?}/bin/.nvcc-wrapped"
makeBinaryWrapper \
Copy link
Contributor

@GaetanLepage GaetanLepage Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using wrapProgram here?

pkgs/development/python-modules/pycuda/default.nix
'';
build-system = [
setuptools
wheel
Copy link
Contributor

@GaetanLepage GaetanLepage Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to get rid of wheel.

@nixpkgs-ci nixpkgs-ci bot requested a review from a team February 10, 2026 05:11
@GaetanLepage
Copy link
Contributor

GaetanLepage commented Feb 10, 2026

@ConnorBaker can you please rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natsukium natsukium Awaiting requested review from natsukium

@prusnak prusnak Awaiting requested review from prusnak

@samuela samuela Awaiting requested review from samuela

@SomeoneSerge SomeoneSerge Awaiting requested review from SomeoneSerge

@GaetanLepage GaetanLepage Awaiting requested review from GaetanLepage

@YorikSar YorikSar Awaiting requested review from YorikSar

Assignees

@ConnorBaker ConnorBaker

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: cuda Parallel computing platform and API 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

CUDA Team
Status: New

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ConnorBaker @GaetanLepage