nixos: sound: warn about changes to defaults (18.03)#46491
Closed
oxij wants to merge 2 commits intoNixOS:release-18.03from
Closed
nixos: sound: warn about changes to defaults (18.03)#46491oxij wants to merge 2 commits intoNixOS:release-18.03from
oxij wants to merge 2 commits intoNixOS:release-18.03from
Conversation
Yeah, it's ugly. But it's the minimal change that doesn't break anything else. (cherry picked from commit 4017fdc)
I still think that change needs to be reverted, but if there's no will for that let's at the very least warn users about the problem that change introduced. Without this most ALSA users switching from releases before 18.03 will get sound, but won't get ALSA state save/restore. That would be very confusing. All modules and tests that want to be completely headless disable this option explicitly. I.e. you won't see this warning unless you are affected. (cherry picked from commit 26934c3)
1 task
Member
|
Not doing backports to 18.03 anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #46490 to 18.03.