Skip to content

nixos: sound: warn about changes to defaults #46490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oxij wants to merge 1 commit into from
Closed

nixos: sound: warn about changes to defaults #46490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions nixos/modules/services/audio/alsa.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ALSA sound support.
{ config, lib, pkgs, ... }:
{ config, options, lib, pkgs, ... }:

with lib;

Expand Down Expand Up @@ -83,7 +83,18 @@ in

###### implementation

config = mkIf config.sound.enable {
config = mkMerge [{

warnings = optional (options.sound.enable.highestPrio > 1000) ''
You don't have `sound.enable` explicitly enabled of disabled. It was
enabled by default before a43e33d0e48b2284ac3a2222d7f1965cef66f5e2 and
became disabled by default after e349ccc77febd45abbd14be14f7de123ec4a4da2.
Copy link
Member

@edolstra edolstra Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no point in including commit hashes in warnings.

Copy link
Member Author

@oxij oxij Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to better suggestions. I don't like being vague like "some commit before 18.03" (which was another option I could come up with) when I can just give the hash (I like doing git show on random hashes I see mentioned in random PRs and comments), but I won't argue against writing whatever else you want if that gets the message across.


Which means that if you output sound via ALSA it will still works, but
your system will no longer save and restore ALSA state between reboots.
'';

} (mkIf config.sound.enable {

environment.systemPackages = [ alsaUtils ];

Expand Down Expand Up @@ -129,6 +140,6 @@ in
];
};

};
})];

}