pkgs/by-name: add version pins#464396
Draft
quantenzitrone wants to merge 11 commits intoNixOS:masterfrom
Draft
Conversation
Contributor
|
Conceptually looks good, what are next steps for this pr? |
Contributor
Author
|
probably get the rfc merged first, or do you think this is small enough to be done without the rfc? |
Contributor
|
we do need to hear opinion of @NixOS/nixpkgs-core at least |
13 tasks
Contributor
I'm not sure what the question to the core team here is. The core team generally is not a code owner that should be pinged for review. However, if local consensus can't be reached, we can surely help out. In this case, the PR is a draft to support an ongoing RFC. The RFC is not done, yet. The PR fails CI. Nothing to do here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept implementation of NixOS/rfcs#192
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.