haskell: export build flags as a shell variable#463887
Merged
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom Dec 26, 2025
Merged
haskell: export build flags as a shell variable#463887wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
This is useful so that you can call `Setup build` on other targets e.g. for code generation while still having the same flags. The context that led me to write this patch is that we have HIE file generation in an overlay at work and I was packaging Glean, which requires a code gen component get built, and it was building twice due to the hie flags not getting propagated to the Setup build commands I was running manually.
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
Contributor
|
Let's target |
wolfgangwalther
approved these changes
Dec 17, 2025
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
Diff LGTM.
We currently don't have a big rebuild on haskell-updates, yet, so we should wait with merging until we do.
nixpkgs-ci
bot
added
12.approvals: 1
Merged
via the queue into
NixOS:haskell-updates
with commit Dec 26, 2025
916a35c
80 of 86 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful so that you can call
Setup buildon other targets e.g. for code generation while still having the same flags.The context that led me to write this patch is that we have HIE file generation in an overlay at work and I was packaging Glean, which requires a code gen component get built, and it was building twice due to the hie flags not getting propagated to the Setup build commands I was running manually. I had to do some silliness with
old.buildFlagsin nix language rather than just using a shell variable, which seemed a little silly.I've sent off a build up to
haskellPackages.aesonto confirm this isn't blatantly broken.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.