nixos/vte: restore lightweight shell integration, build without app; nixos/gdm: generate users#463526
Conversation
fc557de to
e3fe676
Compare
|
Clean up the cherry-pick references in the git commit messages please? (The original commits are not in nixpkgs, according to the github web UI -- and this PR targets master, so it doesn't seem right to cherry-pick to master either.) |
e3fe676 to
e9d5357
Compare
|
Oh yeah, I just started to throw that onto every cherry-pick after taking way to many d-tours in openwrt and backporting here, but removed them from the commits. Can you please take a look at the actual changes? Are they fine? |
The vte changes look good (I also checked the upstream patches), but I stopped at the gdm patch, because it was relatively big, had no justification in the commit message and seemed unrelated to the issue at hand? |
It is only big because it changes indentation and moves a few things around because you cannot define multiple options like |
e9d5357 to
509c89c
Compare
Thanks for the info and update. Approved :-) |
509c89c to
ba247b7
Compare
There was a problem hiding this comment.
Just verified that there are still here after fixing the int to string conversion.
nix-repl> nixosTests.gnome.config.nodes.machine.users.users.gdm
nixosTests.gnome.config.nodes.machine.users.users.gdm nixosTests.gnome.config.nodes.machine.users.users.gdm-greeter-3
nixosTests.gnome.config.nodes.machine.users.users.gdm-greeter nixosTests.gnome.config.nodes.machine.users.users.gdm-greeter-4
nixosTests.gnome.config.nodes.machine.users.users.gdm-greeter-1
nixosTests.gnome.config.nodes.machine.users.users.gdm-greeter-2
nix-repl> nixosTests.gnome.config.nodes.machine.users.users.gdm
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.