Skip to content

nixos/vte: restore lightweight shell integration, build without app; nixos/gdm: generate users#463526

Merged
SuperSandro2000 merged 4 commits intoNixOS:masterfrom
SuperSandro2000:gnome-49-fixes
Nov 22, 2025
Merged

nixos/vte: restore lightweight shell integration, build without app; nixos/gdm: generate users#463526
SuperSandro2000 merged 4 commits intoNixOS:masterfrom
SuperSandro2000:gnome-49-fixes

Conversation

@SuperSandro2000
Copy link
Member

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000 SuperSandro2000 changed the title nixos/vte: restore lightweight shell integration, build without app nixos/vte: restore lightweight shell integration, build without app; nixos/gdm: generate users Nov 20, 2025
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review November 20, 2025 17:43
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 20, 2025
@bjornfor
Copy link
Contributor

Clean up the cherry-pick references in the git commit messages please? (The original commits are not in nixpkgs, according to the github web UI -- and this PR targets master, so it doesn't seem right to cherry-pick to master either.)

@SuperSandro2000
Copy link
Member Author

Oh yeah, I just started to throw that onto every cherry-pick after taking way to many d-tours in openwrt and backporting here, but removed them from the commits.

Can you please take a look at the actual changes? Are they fine?

@bjornfor
Copy link
Contributor

bjornfor commented Nov 21, 2025

Oh yeah, I just started to throw that onto every cherry-pick after taking way to many d-tours in openwrt and backporting here, but removed them from the commits.

Can you please take a look at the actual changes? Are they fine?

The vte changes look good (I also checked the upstream patches), but I stopped at the gdm patch, because it was relatively big, had no justification in the commit message and seemed unrelated to the issue at hand?

@SuperSandro2000
Copy link
Member Author

because it was relatively big, had no justification in the commit message and seemed unrelated to the issue at hand?

It is only big because it changes indentation and moves a few things around because you cannot define multiple options like user.users = at the same level. It reduces the copy paste of the same thing and also fell out of the gnome 49 update.

@bjornfor
Copy link
Contributor

It is only big because it changes indentation and moves a few things around because you cannot define multiple options like user.users = at the same level. It reduces the copy paste of the same thing and also fell out of the gnome 49 update.

Thanks for the info and update. Approved :-)

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 21, 2025
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just verified that there are still here after fixing the int to string conversion.

nix-repl> nixosTests.gnome.config.nodes.machine.users.users.gdm
nixosTests.gnome.config.nodes.machine.users.users.gdm            nixosTests.gnome.config.nodes.machine.users.users.gdm-greeter-3
nixosTests.gnome.config.nodes.machine.users.users.gdm-greeter    nixosTests.gnome.config.nodes.machine.users.users.gdm-greeter-4
nixosTests.gnome.config.nodes.machine.users.users.gdm-greeter-1
nixosTests.gnome.config.nodes.machine.users.users.gdm-greeter-2
nix-repl> nixosTests.gnome.config.nodes.machine.users.users.gdm

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Nov 22, 2025
Merged via the queue into NixOS:master with commit 26868ae Nov 22, 2025
26 of 30 checks passed
@SuperSandro2000 SuperSandro2000 deleted the gnome-49-fixes branch November 22, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants