Skip to content

nixosTests.clangd: init#463394

Closed
jchv wants to merge 1 commit intoNixOS:stagingfrom
jchw-forks:add-clangd-nixos-test
Closed

nixosTests.clangd: init#463394
jchv wants to merge 1 commit intoNixOS:stagingfrom
jchw-forks:add-clangd-nixos-test

Conversation

@jchv
Copy link
Contributor

@jchv jchv commented Nov 20, 2025

Implements a NixOS test for clangd. I was inspired to do this because clangd broke on master and I figured it would be a good idea to have a test for it.

Since the fix is only in staging, I figured targeting staging would make sense. That way the test can fly alongside the fix, which is in #462747.

Related to #463367.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related labels Nov 20, 2025
Copy link
Member

@Patryk27 Patryk27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, I think this can be simplified - I've also added clangd tests as a part of different pull request some time ago 👀

https://github.com/NixOS/nixpkgs/pull/354755/files#diff-42653c93e96edaa584f7622ef3f704df67a115ad7da505b04f06f2cf45c3e54bR54

@jchv
Copy link
Contributor Author

jchv commented Nov 20, 2025

Oh, that's much nicer. In that case, I don't see much of a reason to keep this PR open. Hopefully that PR can be merged soon.

Are passthru tests visible anywhere obvious? I basically just wanted to find a way to make clangd breakages visible faster so they wouldn't make it out of staging as easily.

@jchv jchv closed this Nov 20, 2025
@Patryk27
Copy link
Member

Are passthru tests visible anywhere obvious?

I thiiink they are not automatically propagated anywhere, so adding an explicit entry to all-tests.nix is still a good idea - I'll take a look at that over the weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants