Closed
Conversation
Patryk27
reviewed
Nov 20, 2025
Contributor
Author
|
Oh, that's much nicer. In that case, I don't see much of a reason to keep this PR open. Hopefully that PR can be merged soon. Are passthru tests visible anywhere obvious? I basically just wanted to find a way to make clangd breakages visible faster so they wouldn't make it out of staging as easily. |
Member
I thiiink they are not automatically propagated anywhere, so adding an explicit entry to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a NixOS test for clangd. I was inspired to do this because
clangdbroke onmasterand I figured it would be a good idea to have a test for it.Since the fix is only in
staging, I figured targetingstagingwould make sense. That way the test can fly alongside the fix, which is in #462747.Related to #463367.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.