Skip to content

python3Packages.vllm: 0.11.0 -> 0.11.2#463032

Merged
happysalada merged 1 commit intoNixOS:masterfrom
GaetanLepage:update/python3Packages.vllm
Nov 23, 2025
Merged

python3Packages.vllm: 0.11.0 -> 0.11.2#463032
happysalada merged 1 commit intoNixOS:masterfrom
GaetanLepage:update/python3Packages.vllm

Conversation

@GaetanLepage
Copy link
Copy Markdown
Contributor

@GaetanLepage GaetanLepage commented Nov 18, 2025

Things done

Diff: vllm-project/vllm@v0.11.0...v0.11.2
Changelogs:

cc @happysalada @CertainLach @daniel-fahey

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Nov 18, 2025
@GaetanLepage GaetanLepage force-pushed the update/python3Packages.vllm branch from f6d1a42 to 1316a8f Compare November 19, 2025 00:10
@GaetanLepage GaetanLepage marked this pull request as draft November 19, 2025 09:41
@GaetanLepage GaetanLepage force-pushed the update/python3Packages.vllm branch from 1316a8f to b1fdc25 Compare November 20, 2025 10:29
@daniel-fahey
Copy link
Copy Markdown
Contributor

daniel-fahey commented Nov 20, 2025

Mind closing this in favour of #454872?

Edit: yours covers vllm-project/vllm@bca74e3 too.

Look forward to reviewing.

@GaetanLepage GaetanLepage changed the title python3Packages.vllm: 0.11.0 -> 0.11.1 python3Packages.vllm: 0.11.0 -> 0.11.2 Nov 20, 2025
@GaetanLepage GaetanLepage force-pushed the update/python3Packages.vllm branch 2 times, most recently from 14a056b to b7cfb5b Compare November 20, 2025 10:51
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Nov 20, 2025
@GaetanLepage GaetanLepage force-pushed the update/python3Packages.vllm branch from b7cfb5b to 1b340ea Compare November 20, 2025 11:10
@GaetanLepage GaetanLepage force-pushed the update/python3Packages.vllm branch 2 times, most recently from 60247c2 to cfecfaf Compare November 20, 2025 16:43
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. and removed 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. labels Nov 20, 2025
@GaetanLepage GaetanLepage force-pushed the update/python3Packages.vllm branch from cfecfaf to d1df86e Compare November 21, 2025 10:01
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. labels Nov 21, 2025
@GaetanLepage
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 463032 --package python312Packages.vllm --package python3Packages.vllm
Commit: d1df86e725fa4de3b2e79f861b8b8552718e8dd1


x86_64-linux

✅ 4 packages built:
  • python312Packages.vllm
  • python312Packages.vllm.dist (python312Packages.vllm.dist.dist)
  • python3Packages.vllm
  • python3Packages.vllm.dist (python3Packages.vllm.dist.dist)

aarch64-linux

⏩ 4 packages marked as broken and skipped:
  • python312Packages.vllm
  • python312Packages.vllm.dist
  • python3Packages.vllm
  • python3Packages.vllm.dist

x86_64-darwin

⏩ 4 packages marked as broken and skipped:
  • python312Packages.vllm
  • python312Packages.vllm.dist
  • python3Packages.vllm
  • python3Packages.vllm.dist

aarch64-darwin

⏩ 4 packages marked as broken and skipped:
  • python312Packages.vllm
  • python312Packages.vllm.dist
  • python3Packages.vllm
  • python3Packages.vllm.dist

@GaetanLepage
Copy link
Copy Markdown
Contributor Author

Mind closing this in favour of #454872?

Edit: yours covers vllm-project/vllm@bca74e3 too.

Look forward to reviewing.

Oh I missed that! Sorry.
I think that mine is ready. I'm rebuilding the cuda-enabled package right now.

@GaetanLepage
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 463032 --extra-nixpkgs-config '{ allowUnfree = true; cudaSupport = true; }' --package python313Packages.vllm --package python312Packages.vllm
Commit: d1df86e725fa4de3b2e79f861b8b8552718e8dd1


x86_64-linux

✅ 4 packages built:
  • python312Packages.vllm
  • python312Packages.vllm.dist (python312Packages.vllm.dist.dist)
  • python313Packages.vllm
  • python313Packages.vllm.dist (python313Packages.vllm.dist.dist)

aarch64-linux

⏩ 4 packages marked as broken and skipped:
  • python312Packages.vllm
  • python312Packages.vllm.dist
  • python313Packages.vllm
  • python313Packages.vllm.dist

@GaetanLepage GaetanLepage marked this pull request as ready for review November 22, 2025 15:23
(fetchpatch {
url = "https://github.com/vllm-project/vllm/commit/d7be1f2a480bdc62a6a1ec0126a401e3d42985fe.patch";
hash = "sha256-Zi1k5wiOPjsbWHFKpcLq9Ns43wIP37Mbvesi5K80zaQ=";
})
];

postPatch = ''
# Remove vendored pynvml entirely
rm vllm/third_party/pynvml.py
substituteInPlace tests/utils.py \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__init__.py was refactored into import_utils.py, note:

[daniel@laptop:~/Source/vllm]$ git switch --detach v0.11.2
HEAD is now at 275de3417 [BugFix] Fix false assertion with spec-decode=[2,4,..] and TP>2 (#29036)


[daniel@laptop:~/Source/vllm]$ grep -R vllm.third_party.pynvml --exclude-dir=.git
tests/utils.py:    from vllm.third_party.pynvml import (
vllm/utils/import_utils.py:    import vllm.third_party.pynvml as pynvml

@@ -145,6 +149,15 @@ let
'';
};

# https://github.com/vllm-project/vllm/blob/v${version}/cmake/external_projects/qutlass.cmake
qutlass = fetchFromGitHub {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this needed more ceremony as per https://github.com/daniel-fahey/nixpkgs/blob/4d45e9d901b15422d43c7b1181e5a1ac7e1e0904/pkgs/development/python-modules/vllm/default.nix#L149-L174, but if not, would benefit from adding # grep for GIT_TAG in the following file above # https://github.com/vllm-project/vllm/blob/v${version}/cmake/external_projects/qutlass.cmake for future maintainers.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought too, but it doesn't seem to need any additional dependencies, so I didn't wrap it in stdenv.mkDerivation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the comment.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 22, 2025
@GaetanLepage GaetanLepage force-pushed the update/python3Packages.vllm branch from d1df86e to 6f95270 Compare November 22, 2025 20:54
@GaetanLepage GaetanLepage force-pushed the update/python3Packages.vllm branch from 6f95270 to 3e1a4d4 Compare November 22, 2025 20:57
@GaetanLepage
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 463032 --package python312Packages.vllm --package python3Packages.vllm
Commit: 3e1a4d4ee44de81ee757c8b0a7e3a8edbda78768


x86_64-linux

✅ 4 packages built:
  • python312Packages.vllm
  • python312Packages.vllm.dist (python312Packages.vllm.dist.dist)
  • python3Packages.vllm
  • python3Packages.vllm.dist (python3Packages.vllm.dist.dist)

aarch64-linux

⏩ 4 packages marked as broken and skipped:
  • python312Packages.vllm
  • python312Packages.vllm.dist
  • python3Packages.vllm
  • python3Packages.vllm.dist

x86_64-darwin

⏩ 4 packages marked as broken and skipped:
  • python312Packages.vllm
  • python312Packages.vllm.dist
  • python3Packages.vllm
  • python3Packages.vllm.dist

aarch64-darwin

⏩ 4 packages marked as broken and skipped:
  • python312Packages.vllm
  • python312Packages.vllm.dist
  • python3Packages.vllm
  • python3Packages.vllm.dist

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 22, 2025
@happysalada happysalada added this pull request to the merge queue Nov 23, 2025
Merged via the queue into NixOS:master with commit e2e2ccd Nov 23, 2025
29 of 31 checks passed
@GaetanLepage GaetanLepage deleted the update/python3Packages.vllm branch November 23, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants