python3Packages.vllm: 0.11.0 -> 0.11.2#463032
Conversation
f6d1a42 to
1316a8f
Compare
1316a8f to
b1fdc25
Compare
|
Edit: yours covers vllm-project/vllm@bca74e3 too. Look forward to reviewing. |
14a056b to
b7cfb5b
Compare
b7cfb5b to
1b340ea
Compare
60247c2 to
cfecfaf
Compare
cfecfaf to
d1df86e
Compare
|
Oh I missed that! Sorry. |
|
| (fetchpatch { | ||
| url = "https://github.com/vllm-project/vllm/commit/d7be1f2a480bdc62a6a1ec0126a401e3d42985fe.patch"; | ||
| hash = "sha256-Zi1k5wiOPjsbWHFKpcLq9Ns43wIP37Mbvesi5K80zaQ="; | ||
| }) | ||
| ]; | ||
|
|
||
| postPatch = '' | ||
| # Remove vendored pynvml entirely | ||
| rm vllm/third_party/pynvml.py | ||
| substituteInPlace tests/utils.py \ |
There was a problem hiding this comment.
__init__.py was refactored into import_utils.py, note:
[daniel@laptop:~/Source/vllm]$ git switch --detach v0.11.2
HEAD is now at 275de3417 [BugFix] Fix false assertion with spec-decode=[2,4,..] and TP>2 (#29036)
[daniel@laptop:~/Source/vllm]$ grep -R vllm.third_party.pynvml --exclude-dir=.git
tests/utils.py: from vllm.third_party.pynvml import (
vllm/utils/import_utils.py: import vllm.third_party.pynvml as pynvml| @@ -145,6 +149,15 @@ let | |||
| ''; | |||
| }; | |||
|
|
|||
| # https://github.com/vllm-project/vllm/blob/v${version}/cmake/external_projects/qutlass.cmake | |||
| qutlass = fetchFromGitHub { | |||
There was a problem hiding this comment.
I thought this needed more ceremony as per https://github.com/daniel-fahey/nixpkgs/blob/4d45e9d901b15422d43c7b1181e5a1ac7e1e0904/pkgs/development/python-modules/vllm/default.nix#L149-L174, but if not, would benefit from adding # grep for GIT_TAG in the following file above # https://github.com/vllm-project/vllm/blob/v${version}/cmake/external_projects/qutlass.cmake for future maintainers.
There was a problem hiding this comment.
I thought too, but it doesn't seem to need any additional dependencies, so I didn't wrap it in stdenv.mkDerivation.
There was a problem hiding this comment.
I added the comment.
d1df86e to
6f95270
Compare
6f95270 to
3e1a4d4
Compare
|
Things done
Diff: vllm-project/vllm@v0.11.0...v0.11.2
Changelogs:
cc @happysalada @CertainLach @daniel-fahey
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.