Skip to content

eb-garamond: disable ttfautohint's GUI#463023

Merged
Aleksanaa merged 2 commits intoNixOS:stagingfrom
bengsparks:eb-garamond-fontforge
Dec 1, 2025
Merged

eb-garamond: disable ttfautohint's GUI#463023
Aleksanaa merged 2 commits intoNixOS:stagingfrom
bengsparks:eb-garamond-fontforge

Conversation

@bengsparks
Copy link
Contributor

@bengsparks bengsparks commented Nov 18, 2025

The darwin build will likely continue working once staging(-next) has been merged into master again.
This simply remove the GUI dependencies from the package's closure.

ben at BenjaminsLaptop in ~/coding/nixpkgs (master) 
$ nom-build -A eb-garamond --system aarch64-linux
warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels' does not exist, ignoring
Finished at 23:29:22 after 1s
/nix/store/dplp9520hvsh0kkv4c1p4r9106fzb2zz-eb-garamond-0.016
ben at BenjaminsLaptop in ~/coding/nixpkgs (master) 
$ nom-build -A eb-garamond --system x86_64-linux 
warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels' does not exist, ignoring
this path will be fetched (2.24 MiB download, 5.69 MiB unpacked):
  /nix/store/xbvwwz2yva8vnc122xq42zzqxrf5zp0j-eb-garamond-0.016
copying path '/nix/store/xbvwwz2yva8vnc122xq42zzqxrf5zp0j-eb-garamond-0.016' from 'https://cache.nixos.org'
┏━━━ Downloads       │ Host                         
┃        │     │     │ localhost                    
┃        │ ↓ 1 │     │ https://cache.nixos.org      
┗━ ∑ ↓ 0 │ ↓ 1 │ ⏸ 0 │ Finished at 23:29:32 after 6s
/nix/store/xbvwwz2yva8vnc122xq42zzqxrf5zp0j-eb-garamond-0.016

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot requested review from relrod and rycee November 18, 2025 22:39
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 18, 2025
@bengsparks bengsparks requested a review from NickCao November 18, 2025 22:44
@bengsparks bengsparks force-pushed the eb-garamond-fontforge branch 3 times, most recently from c43f7ce to 5f5b748 Compare November 18, 2025 23:13
@bengsparks bengsparks changed the title eb-garamond: fix build on darwin eb-garamond: disable ttfautohint's GUI Nov 18, 2025
@bengsparks

This comment was marked as outdated.

@bengsparks
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 463023
Commit: 5f5b7489a58c6aca6e4da0bc19a16ef50a0a80ae


x86_64-linux

❌ 1 package failed to build:
  • eb-garamond

aarch64-linux

✅ 1 package built:
  • eb-garamond

x86_64-darwin

❌ 1 package failed to build:
  • eb-garamond

aarch64-darwin

❌ 1 package failed to build:
  • eb-garamond

Error logs: `x86_64-linux`
eb-garamond
source root is source
Running phase: patchPhase
@nix {"action":"setPhase","phase":"patchPhase"}
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix {"action":"setPhase","phase":"updateAutotoolsGnuConfigScriptsPhase"}
Running phase: configurePhase
@nix {"action":"setPhase","phase":"configurePhase"}
no configure script, doing nothing
Running phase: buildPhase
@nix {"action":"setPhase","phase":"buildPhase"}
Makefile:43: warning: overriding recipe for target 'build'
Makefile:41: warning: ignoring old recipe for target 'build'
Generating	build/EBGaramond08-Regular.otf
/build/source/tools/makefont.py:43: SyntaxWarning: invalid escape sequence '\d'
  inferred_style = re.search('\d+-\w+', font_source_name).group(0)
Traceback (most recent call last):
  File "/build/source/tools/makefont.py", line 10, in 
    import fontforge
ModuleNotFoundError: No module named 'fontforge'
make: *** [Makefile:49: build/EBGaramond08-Regular.otf] Error 1

Error logs: `x86_64-darwin`
eb-garamond
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/2jq9gmysgwm5qh561dnrvnf25gddakjr-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
no configure script, doing nothing
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Makefile:43: warning: overriding recipe for target 'build'
Makefile:41: warning: ignoring old recipe for target 'build'
Generating	build/EBGaramond08-Regular.otf
/nix/var/nix/builds/nix-build-eb-garamond-0.016.drv-0/source/tools/makefont.py:43: SyntaxWarning: invalid escape sequence '\d'
  inferred_style = re.search('\d+-\w+', font_source_name).group(0)
Traceback (most recent call last):
  File "/nix/var/nix/builds/nix-build-eb-garamond-0.016.drv-0/source/tools/makefont.py", line 10, in 
    import fontforge
ModuleNotFoundError: No module named 'fontforge'
make: *** [Makefile:49: build/EBGaramond08-Regular.otf] Error 1

Error logs: `aarch64-darwin`
eb-garamond
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
no configure script, doing nothing
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Makefile:43: warning: overriding recipe for target 'build'
Makefile:41: warning: ignoring old recipe for target 'build'
Generating	build/EBGaramond08-Regular.otf
/nix/var/nix/builds/nix-build-eb-garamond-0.016.drv-0/source/tools/makefont.py:43: SyntaxWarning: invalid escape sequence '\d'
  inferred_style = re.search('\d+-\w+', font_source_name).group(0)
Traceback (most recent call last):
  File "/nix/var/nix/builds/nix-build-eb-garamond-0.016.drv-0/source/tools/makefont.py", line 10, in 
    import fontforge
ModuleNotFoundError: No module named 'fontforge'
make: *** [Makefile:49: build/EBGaramond08-Regular.otf] Error 1

@mrshmllow
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 463023
Commit: 5f5b7489a58c6aca6e4da0bc19a16ef50a0a80ae


x86_64-linux

✅ 1 package built:
  • eb-garamond

aarch64-linux

✅ 1 package built:
  • eb-garamond

@Aleksanaa
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 463023
Commit: 5f5b7489a58c6aca6e4da0bc19a16ef50a0a80ae (subsequent changes)
Merge: 1b43ed797037cd39fc51eacb8cfe81115a2cb11c

Logs: https://github.com/Aleksanaa/nixpkgs-review-gha/actions/runs/19722682411


x86_64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • eb-garamond

Error logs: `x86_64-darwin`
eb-garamond
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/2jq9gmysgwm5qh561dnrvnf25gddakjr-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
no configure script, doing nothing
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Makefile:43: warning: overriding recipe for target 'build'
Makefile:41: warning: ignoring old recipe for target 'build'
Generating	build/EBGaramond08-Regular.otf
/nix/build/nix-7844-3163790417/source/tools/makefont.py:43: SyntaxWarning: invalid escape sequence '\d'
  inferred_style = re.search('\d+-\w+', font_source_name).group(0)
Traceback (most recent call last):
  File "/nix/build/nix-7844-3163790417/source/tools/makefont.py", line 10, in <module>
    import fontforge
ModuleNotFoundError: No module named 'fontforge'
make: *** [Makefile:49: build/EBGaramond08-Regular.otf] Error 1

aarch64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • eb-garamond

Error logs: `aarch64-darwin`
eb-garamond
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
no configure script, doing nothing
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Makefile:43: warning: overriding recipe for target 'build'
Makefile:41: warning: ignoring old recipe for target 'build'
Generating	build/EBGaramond08-Regular.otf
/nix/build/nix-5619-2638115152/source/tools/makefont.py:43: SyntaxWarning: invalid escape sequence '\d'
  inferred_style = re.search('\d+-\w+', font_source_name).group(0)
Traceback (most recent call last):
  File "/nix/build/nix-5619-2638115152/source/tools/makefont.py", line 10, in <module>
    import fontforge
ModuleNotFoundError: No module named 'fontforge'
make: *** [Makefile:49: build/EBGaramond08-Regular.otf] Error 1

@m4r1vs m4r1vs mentioned this pull request Nov 28, 2025
3 tasks
@m4r1vs
Copy link

m4r1vs commented Nov 28, 2025

Fixed the darwin build failure with this overlay for now:

eb-garamond = prev.eb-garamond.overrideAttrs {
  nativeBuildInputs = with prev; [
    fontforge
    python3
    ttfautohint-nox
  ];
};

@bengsparks
Copy link
Contributor Author

bengsparks commented Nov 30, 2025

There have been some changes to Python and PYTHONPATH in nixpkgs, the last of which has not yet landed in master. I expect this last one to fix this package's build by itself. If not, I will adapt the suggested change.

@bengsparks bengsparks force-pushed the eb-garamond-fontforge branch from 5f5b748 to 8151f33 Compare December 1, 2025 16:02
@bengsparks bengsparks changed the base branch from master to staging December 1, 2025 16:02
@nixpkgs-ci nixpkgs-ci bot closed this Dec 1, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Dec 1, 2025
@bengsparks
Copy link
Contributor Author

I can confirm that building on staging fixes the build for darwin, so I will just adapt this PR to staging instead of waiting for the merge 😄

@Aleksanaa Aleksanaa added this pull request to the merge queue Dec 1, 2025
Merged via the queue into NixOS:staging with commit 542c434 Dec 1, 2025
34 of 36 checks passed
@bengsparks bengsparks deleted the eb-garamond-fontforge branch December 1, 2025 16:23
@bengsparks bengsparks added the backport staging-25.11 Backport PR automatically label Dec 5, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 5, 2025

Successfully created backport PR for staging-25.11:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. backport staging-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants