Skip to content

nixos/nemorosa: init service#462968

Open
undefined-landmark wants to merge 2 commits intoNixOS:masterfrom
undefined-landmark:nemorosa-service
Open

nixos/nemorosa: init service#462968
undefined-landmark wants to merge 2 commits intoNixOS:masterfrom
undefined-landmark:nemorosa-service

Conversation

@undefined-landmark
Copy link
Contributor

@undefined-landmark undefined-landmark commented Nov 18, 2025 •
edited
Loading

Add nixos module for the nemorosa package. Largely inspired by the cross-seed and recyclarr modules.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 18, 2025
@undefined-landmark undefined-landmark force-pushed the nemorosa-service branch 3 times, most recently from 4ed67e9 to 41ce805 Compare January 3, 2026 16:18
@undefined-landmark undefined-landmark changed the title nixos/nemorosa: init nemorosa service nixos/nemorosa: init service Jan 3, 2026
@undefined-landmark undefined-landmark force-pushed the nemorosa-service branch 3 times, most recently from 93bd6ba to e5974cc Compare January 4, 2026 16:35
@undefined-landmark undefined-landmark marked this pull request as ready for review January 4, 2026 17:05
@nixpkgs-ci nixpkgs-ci bot requested a review from ambroisie January 4, 2026 17:13
ambroisie
ambroisie reviewed Jan 4, 2026
View reviewed changes
Copy link
Contributor

@ambroisie ambroisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, a few comments.

@undefined-landmark
Copy link
Contributor Author

undefined-landmark commented Jan 5, 2026

Thanks for the quick review! Learned some new things resolving the comments. Still two points I'm not entirely sure about. See the open comment threads.

@undefined-landmark undefined-landmark force-pushed the nemorosa-service branch 3 times, most recently from fe277cf to 6f66674 Compare January 6, 2026 07:43
@undefined-landmark
Copy link
Contributor Author

undefined-landmark commented Jan 6, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 462968 --package nixosTests.nemorosa
Commit: 6f666745ca7dd714791fdb4b6baf7b85786040cc

x86_64-linux

✅ 1 test built:
  • nixosTests.nemorosa

@nixpkgs-ci nixpkgs-ci bot added 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Jan 6, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 6, 2026
@undefined-landmark undefined-landmark mentioned this pull request Jan 7, 2026
Merged
13 tasks
@undefined-landmark
Copy link
Contributor Author

undefined-landmark commented Jan 7, 2026

Forgot to add myself as a maintainer... That's fixed now.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambroisie ambroisie ambroisie approved these changes

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@undefined-landmark @ambroisie