Skip to content

ruby: Drop cargo, it's not used by yjit#462631

Merged
kirillrdy merged 1 commit intoNixOS:stagingfrom
samueldr:fix/ruby-no-cargo-needed
Nov 18, 2025
Merged

ruby: Drop cargo, it's not used by yjit#462631
kirillrdy merged 1 commit intoNixOS:stagingfrom
samueldr:fix/ruby-no-cargo-needed

Conversation

@samueldr
Copy link
Member

@samueldr samueldr commented Nov 17, 2025 •
edited
Loading

Only $RUSTC, which desugars to rustc by default, is used for yjit. Note that the plumbing for cargo does exist, but is used for development purposes only.

This PR is the rebuild-heavy commit initially in #461684.

See: #461684 (comment)

cc: @kirillrdy.

Things done

  • Built on platform:
    • x86_64-linux (from nixos-unstable, not from staging)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@samueldr
ruby: Drop cargo, it's not used by yjit
5f50a55 
 - https://github.com/ruby/ruby/blob/0b559eab0447905a784092824e5ea0999018cd01/yjit/yjit.mk#L22-L27

Only `$RUSTC`, which desugars to `rustc` by default, is used for yjit.
Note that the plumbing for cargo does exist, but is used for development
purposes only.

Signed-off-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
(cherry picked from commit 90e5b96)
@samueldr samueldr mentioned this pull request Nov 17, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot requested a review from manveru November 17, 2025 17:37
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. labels Nov 17, 2025
kirillrdy
kirillrdy approved these changes Nov 18, 2025
View reviewed changes
Copy link
Member

@kirillrdy kirillrdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 462631 --package ruby
Commit: 5f50a5563f6b37f95cec060ebbf4e2f99b3f7ac4

x86_64-linux

✅ 2 packages built:
  • ruby
  • ruby.devdoc (ruby.devdoc.devdoc)

@kirillrdy kirillrdy added this pull request to the merge queue Nov 18, 2025
Merged via the queue into NixOS:staging with commit 5ab805c Nov 18, 2025
33 of 36 checks passed
@samueldr samueldr deleted the fix/ruby-no-cargo-needed branch November 18, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirillrdy kirillrdy kirillrdy approved these changes

@manveru manveru Awaiting requested review from manveru

Assignees

No one assigned

Labels

6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samueldr @kirillrdy