haskellPackages.mkDerivation: faster haddockPhase#462361
Merged
wolfgangwalther merged 2 commits intoNixOS:haskell-updatesfrom Dec 26, 2025
Merged
haskellPackages.mkDerivation: faster haddockPhase#462361wolfgangwalther merged 2 commits intoNixOS:haskell-updatesfrom
wolfgangwalther merged 2 commits intoNixOS:haskell-updatesfrom
Conversation
this avoids file operations that are not needed in nixpkgs
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
wolfgangwalther
requested review from
maralorn,
sternenseemann and
wolfgangwalther
nixpkgs-ci
bot
removed
the
9.needs: reviewer
Contributor
Author
|
@sternenseemann @maralorn @wolfgangwalther any thoughts on this one? |
wolfgangwalther
approved these changes
Dec 8, 2025
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
Diff LGTM, will defer to @sternenseemann to decide whether to try it this cycle.
nixpkgs-ci
bot
added
12.approvals: 1
Contributor
Which package in Nixpkgs can we try this on? |
Contributor
Author
|
The 10 seconds was for |
Contributor
Author
|
Before this patch on After this patch on |
Contributor
|
I see the same speedup. Not merging immediately, because we currently don't have a full rebuild going - but once we do, we should. |
Merged
via the queue into
NixOS:haskell-updates
with commit Dec 26, 2025
861a65f
37 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From my understanding the
-jflag has not been passed to haddock. I used--haddock-option=--trace-argsto return all the arguments passed by nixpkgs and-jis not in that output.Also running a
time nix build #myPkg.docis now 10 seconds faster for one of my packages.More controversial the second commit adds
--no-tmp-comp-dirto remove a bit of IO. We don't need that as the nix build directory is already our temp directory.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.