haskellPackages.text-icu: disable homebrew flag#462106
Merged
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom Nov 17, 2025
Merged
haskellPackages.text-icu: disable homebrew flag#462106wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
c0082f5 to
93970d6
Compare
sternenseemann
requested changes
Nov 16, 2025
93970d6 to
a830ce8
Compare
By default text-icu sets homebrew=true. This can cause a nix build of text-icu to accidentally link the homebrew icu. It can also cause "doesn't work on my machine" issues when an old homebrew version with icu is installed on a mac and is accidentally picked up.
a830ce8 to
9d8a1ff
Compare
sternenseemann
approved these changes
Nov 16, 2025
Merged
via the queue into
NixOS:haskell-updates
with commit Nov 17, 2025
f0c4be0
29 of 32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default text-icu sets homebrew=true. This can cause a nix build of text-icu to accidentally link the homebrew icu. It can also cause "doesn't work on my machine" issues when an old homebrew version with icu is installed on a mac and is accidentally picked up.
See #462046
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.