Skip to content

haskellPackages.text-icu: disable homebrew flag#462106

Merged
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
mpscholten:fix-text-icu
Nov 17, 2025
Merged

haskellPackages.text-icu: disable homebrew flag#462106
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
mpscholten:fix-text-icu

Conversation

@mpscholten
Copy link
Contributor

By default text-icu sets homebrew=true. This can cause a nix build of text-icu to accidentally link the homebrew icu. It can also cause "doesn't work on my machine" issues when an old homebrew version with icu is installed on a mac and is accidentally picked up.

See #462046

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Nov 16, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 16, 2025
By default text-icu sets homebrew=true. This can cause a nix build
of text-icu to accidentally link the homebrew icu. It can also
cause "doesn't work on my machine" issues when an old homebrew version
with icu is installed on a mac and is accidentally picked up.
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 16, 2025
@wolfgangwalther wolfgangwalther added this pull request to the merge queue Nov 17, 2025
Merged via the queue into NixOS:haskell-updates with commit f0c4be0 Nov 17, 2025
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants