Skip to content

Comments

[25.05] podman-desktop: 1.19.1 -> 1.22.1; bump to electron_38#462053

Merged
nixpkgs-ci[bot] merged 11 commits intoNixOS:release-25.05from
booxter:podman-desktop-2505
Nov 16, 2025
Merged

[25.05] podman-desktop: 1.19.1 -> 1.22.1; bump to electron_38#462053
nixpkgs-ci[bot] merged 11 commits intoNixOS:release-25.05from
booxter:podman-desktop-2505

Conversation

@booxter
Copy link
Contributor

@booxter booxter commented Nov 15, 2025

  • podman-desktop: Remove usage of finalAttrs.pname
  • podman-desktop: 1.19.1 -> 1.19.2
  • podman-desktop: 1.19.2 -> 1.20.0
  • podman-desktop: force disable electron-builder signing on arm64
  • podman-desktop: 1.20.0 -> 1.20.1
  • podman-desktop: 1.20.1 -> 1.20.2
  • podman-desktop: add podman to PATH
  • podman-desktop: remove @panda2134 from maintainers
  • podman-desktop: 1.20.2 -> 1.21.0
  • podman-desktop: 1.21.0 -> 1.22.0
  • podman-desktop: 1.22.0 -> 1.22.1

Related: #461995

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

guylamar2006 and others added 11 commits November 15, 2025 16:38
(cherry picked from commit 7e68b95)
(cherry picked from commit dbef563)
Even with CSC_IDENTITY_AUTO_DISCOVERY=false, latest builder attempts to
sign if on arm64 unless identity is forcefully set to `null`.

The problem that builder tries to solve with falling back to an ad-hoc
signature doesn't affect us because we later sign binaries with our own
hook. So it should be safe to disable builder's signature logic.

(cherry picked from commit a1fcfb6)
(cherry picked from commit 5a40ba6)
(cherry picked from commit 84f31cc)
Otherwise, the basic app functionality - managing containers - requires
a manual configuration of the path to the podman binary.

Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
(cherry picked from commit 2411f10)
(cherry picked from commit fd3b748)
(cherry picked from commit 97681c0)
@booxter booxter changed the title podman-desktop: 1.19.1 -> 1.22.0; bump to electron_38 podman-desktop: 1.19.1 -> 1.22.1; bump to electron_38 Nov 15, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 4.workflow: backport This targets a stable branch labels Nov 15, 2025
@booxter booxter marked this pull request as ready for review November 15, 2025 22:21
@nixpkgs-ci nixpkgs-ci bot requested a review from panda2134 November 15, 2025 22:32
@booxter
Copy link
Contributor Author

booxter commented Nov 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 462053
Commit: 37d1472984763c1f54f8332eed459af4bb54a09f


x86_64-linux

✅ 1 package built:
  • podman-desktop

aarch64-linux

✅ 1 package built:
  • podman-desktop

x86_64-darwin

✅ 1 package built:
  • podman-desktop

aarch64-darwin

✅ 1 package built:
  • podman-desktop

@booxter
Copy link
Contributor Author

booxter commented Nov 15, 2025

Confirmed the app opens on both Linux (x86_64) and Darwin (aarch64).

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM except 2 small things I would like to see addressed before merging.

@booxter booxter changed the title podman-desktop: 1.19.1 -> 1.22.1; bump to electron_38 [25.05] podman-desktop: 1.19.1 -> 1.22.1; bump to electron_38 Nov 16, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Nov 16, 2025
@booxter
Copy link
Contributor Author

booxter commented Nov 16, 2025

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Nov 16, 2025

@booxter wants to merge this PR.

Requirements to merge this PR with @NixOS/nixpkgs-merge-bot merge:

  • ✅ PR targets a development branch.
  • ✅ PR touches only files of packages in pkgs/by-name/.
  • ✅ PR is at least one of:
    • ✅ Approved by a committer.
    • ⬜ Backported via label.
    • ⬜ Opened by a committer.
    • ⬜ Opened by r-ryantm.
  • ✅ booxter is a member of @NixOS/nixpkgs-maintainers.
  • ✅ booxter is a maintainer of all touched packages.

✔️ Queued for merge (#306934)

@nixpkgs-ci nixpkgs-ci bot added this pull request to the merge queue Nov 16, 2025
Merged via the queue into NixOS:release-25.05 with commit 4c8cdd5 Nov 16, 2025
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 4.workflow: backport This targets a stable branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants