python3Packages.amazon-ion: include c_ext module#461391
Merged
dotlambda merged 1 commit intoNixOS:masterfrom Dec 11, 2025
Merged
python3Packages.amazon-ion: include c_ext module#461391dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda merged 1 commit intoNixOS:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
github-actions
bot
added
the
6.topic: policy discussion
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
ony
force-pushed
the
push-kvwspzupopzp
branch
from
83f27aa to
af0e150
Compare
nixpkgs-ci
bot
added
the
2.status: merge conflict
ony
force-pushed
the
push-kvwspzupopzp
branch
from
af0e150 to
aa76db8
Compare
nixpkgs-ci
bot
removed
2.status: merge conflict
ony
force-pushed
the
push-kvwspzupopzp
branch
from
aa76db8 to
4b6dea0
Compare
ony
force-pushed
the
push-kvwspzupopzp
branch
from
4b6dea0 to
86db55e
Compare
3 tasks
dotlambda
changed the title
dotlambda
reviewed
Dec 5, 2025
ony
force-pushed
the
push-kvwspzupopzp
branch
from
86db55e to
5a9e2c1
Compare
ony
force-pushed
the
push-kvwspzupopzp
branch
from
5a9e2c1 to
6a4a9ba
Compare
Contributor
Author
nix shell .\#nixpkgs-review
nixpkgs-review rev --print-result 6a4a9ba4
|
dotlambda
reviewed
Dec 7, 2025
ony
commented
Dec 7, 2025
ony
force-pushed
the
push-kvwspzupopzp
branch
3 times, most recently
from
6f34c2f to
98f52f7
Compare
Member
|
Member
|
I guess |
Contributor
Author
Ehh... I can try to play with P.S. Thank you for helping and for quick feedback. |
ony
force-pushed
the
push-kvwspzupopzp
branch
from
98f52f7 to
aca443b
Compare
Draft
13 tasks
dotlambda
reviewed
Dec 8, 2025
This should bring 60x speed up in parsing text Ion. Resolves NixOS#461284
ony
force-pushed
the
push-kvwspzupopzp
branch
from
aca443b to
a76d0f2
Compare
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address problem of slow
amazon-ionpackage due to miss of C extension module (link claiming 60x speedup vs pure implementation).See #461284
Latest release of ion-python/amazon-ion at the moment is 0.13.0 where submodule is pointing to commit of ion-c with version 1.1.2.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage ²../result/bin/¹.¹ Tested effect with next commands
(changed folder so
pythonwill load modulers relative to builtsite-packagesfolder whereamazonpackage/module resides)python -c 'import amazon.ion.simpleion as ion; print(ion.__IS_C_EXTENSION_SUPPORTED)'True² part of the output of
nixpkgs-review rev --print-result 4b6dea07(prfails withurllib.error.HTTPError: HTTP Error 401: Unauthorized)nixpkgs-reviewresultGenerated using
nixpkgs-review.Command:
nixpkgs-reviewCommit:
4b6dea07193748d86a1a2ff889e9f6bc0c0e8e37x86_64-linux✅ 8 packages built:
Add a 👍 reaction to pull requests you find important.