Skip to content

nixos/ipa: krb5Full has been renamed to krb5#461291

Merged
benley merged 1 commit intoNixOS:masterfrom
benley:ipa-krb5Full
Nov 14, 2025
Merged

nixos/ipa: krb5Full has been renamed to krb5#461291
benley merged 1 commit intoNixOS:masterfrom
benley:ipa-krb5Full

Conversation

@benley
Copy link
Member

@benley benley commented Nov 13, 2025

Make ipa.nix depend on krb5 instead of the deprecated krb5Full.

This broke with #456065. The krb5Full attribute rename started way back in 2022 with #201707, and I guess ipa.nix was overlooked because it has no associated nixos tests.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@benley
nixos/ipa: krb5Full has been renamed to krb5
5857fd7 
This broke as of NixOS#456065.  krb5Full rename started way back in 2022
with NixOS#201707, and I guess ipa.nix was overlooked.
@benley benley mentioned this pull request Nov 13, 2025
Open
3 tasks
@benley
Copy link
Member Author

benley commented Nov 13, 2025

cc @MarcelCoding, @s1341, @h7x4

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 13, 2025
@benley benley added this pull request to the merge queue Nov 13, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Nov 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2025
@benley
Copy link
Member Author

benley commented Nov 14, 2025

alright, the merge queue is failing with something totally unrelated so I'm going to bypass it for this one. Hope that is OK.

@benley benley merged commit 81c927e into NixOS:master Nov 14, 2025
33 of 36 checks passed
@benley benley deleted the ipa-krb5Full branch November 14, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MarcelCoding MarcelCoding MarcelCoding approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benley @MarcelCoding