Skip to content

Comments

electron-{source,bin,chromedriver}: updates, electron-source_39: fix build#460922

Merged
yuyuyureka merged 12 commits intoNixOS:masterfrom
teutat3s:electron-39-fix-build
Nov 15, 2025
Merged

electron-{source,bin,chromedriver}: updates, electron-source_39: fix build#460922
yuyuyureka merged 12 commits intoNixOS:masterfrom
teutat3s:electron-39-fix-build

Conversation

@teutat3s
Copy link
Member

@teutat3s teutat3s commented Nov 12, 2025 •
edited
Loading

Changelog: https://github.com/electron/electron/releases/tag/v37.10.0
Diff: electron/electron@refs/tags/v37.9.0...v37.10.0

Changelog: https://github.com/electron/electron/releases/tag/v38.7.0
Diff: electron/electron@refs/tags/v38.6.0...v38.7.0

Changelog: https://github.com/electron/electron/releases/tag/v39.1.2
Diff: electron/electron@refs/tags/v39.1.1...v39.1.2
Changelog: https://github.com/electron/electron/releases/tag/v39.2.0
Diff: electron/electron@refs/tags/v39.1.2...v39.2.0

Fixes build of electron_39 that was mentioned in #459455 (comment), breaking change was in commit 6236808.

ZHF: #457852

Fixes #461712

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@teutat3s teutat3s mentioned this pull request Nov 12, 2025
Merged
13 tasks
@teutat3s teutat3s added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 12, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Nov 12, 2025
@yayayayaka
Copy link
Member

yayayayaka commented Nov 14, 2025

Building on x86_64-linux

@yayayayaka
Copy link
Member

yayayayaka commented Nov 14, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 460922
Commit: a3d430ec15d1c20f61f7e8c26ff7e3b6859f191c

x86_64-linux

✅ 4 packages built:
  • electron-chromedriver_39
  • electron_39
  • electron_39-bin
  • netron

@teutat3s
Copy link
Member Author

teutat3s commented Nov 14, 2025

There are more updates incoming ...

@teutat3s teutat3s changed the title electron-{source,bin,chromedriver}_39: 39.1.1 -> 39.1.2, electron-source_39: fix build electron-{source,bin,chromedriver}: updates, electron-source_39: fix build Nov 14, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Nov 14, 2025
@teutat3s
Copy link
Member Author

teutat3s commented Nov 14, 2025

Building on aarch64-linux...

@teutat3s teutat3s mentioned this pull request Nov 14, 2025
Closed
3 tasks
@yuyuyureka
Copy link
Contributor

yuyuyureka commented Nov 14, 2025

How are you planning to fix the build of electron_39? It is broken, because an outdated gclient2nix / NIX_PATH was used when running the update script (it must include 4dc9b83).

yuyuyureka
yuyuyureka previously requested changes Nov 14, 2025
View reviewed changes
Copy link
Contributor

@yuyuyureka yuyuyureka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You first fixed electron_39 build, and then broke it again in 5bcfc655f07e1ca4e7db969044cb8b58454810f3

@teutat3s teutat3s force-pushed the electron-39-fix-build branch from 5bcfc65 to 2a58ac2 Compare November 15, 2025 03:30
@teutat3s
Copy link
Member Author

teutat3s commented Nov 15, 2025

Yep, fixed again.

@teutat3s
electron-source.electron_39: 39.1.1 -> 39.1.2
6d725e9 
- Changelog: https://github.com/electron/electron/releases/tag/v39.1.2
- Diff: electron/electron@refs/tags/v39.1.1...v39.1.2
@teutat3s
electron_39-bin: 39.1.1 -> 39.1.2
7f3d3b2 
- Changelog: https://github.com/electron/electron/releases/tag/v39.1.2
- Diff: electron/electron@refs/tags/v39.1.1...v39.1.2
@teutat3s
electron-chromedriver_39: 39.1.1 -> 39.1.2
656ce16 
- Changelog: https://github.com/electron/electron/releases/tag/v39.1.2
- Diff: electron/electron@refs/tags/v39.1.1...v39.1.2
@teutat3s
electron_37-bin: 37.9.0 -> 37.10.0
17e9e94 
- Changelog: https://github.com/electron/electron/releases/tag/v37.10.0
- Diff: electron/electron@refs/tags/v37.9.0...v37.10.0
@teutat3s
electron-chromedriver_37: 37.9.0 -> 37.10.0
59fdb16 
- Changelog: https://github.com/electron/electron/releases/tag/v37.10.0
- Diff: electron/electron@refs/tags/v37.9.0...v37.10.0
@teutat3s
electron_38-bin: 38.6.0 -> 38.7.0
615fe08 
- Changelog: https://github.com/electron/electron/releases/tag/v38.7.0
- Diff: electron/electron@refs/tags/v38.6.0...v38.7.0
@teutat3s
electron-chromedriver_38: 38.6.0 -> 38.7.0
bb67d8b 
- Changelog: https://github.com/electron/electron/releases/tag/v38.7.0
- Diff: electron/electron@refs/tags/v38.6.0...v38.7.0
@teutat3s
electron_39-bin: 39.1.2 -> 39.2.0
c0a4604 
- Changelog: https://github.com/electron/electron/releases/tag/v39.2.0
- Diff: electron/electron@refs/tags/v39.1.2...v39.2.0
@teutat3s
electron-chromedriver_39: 39.1.2 -> 39.2.0
fab8a82 
- Changelog: https://github.com/electron/electron/releases/tag/v39.2.0
- Diff: electron/electron@refs/tags/v39.1.2...v39.2.0
@teutat3s
electron-source.electron_37: 37.9.0 -> 37.10.0
8ad8283 
- Changelog: https://github.com/electron/electron/releases/tag/v37.10.0
- Diff: electron/electron@refs/tags/v37.9.0...v37.10.0
@teutat3s teutat3s force-pushed the electron-39-fix-build branch from 2a58ac2 to 7903623 Compare November 15, 2025 03:41
@leona-ya leona-ya added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 15, 2025
@leona-ya
Copy link
Member

leona-ya commented Nov 15, 2025 •
edited
Loading

Electron 39.1.2 includes a updated chromium that fixed multiple vulnerabilities: https://chromereleases.googleblog.com/2025/11/stable-channel-update-for-desktop.html

leona-ya
leona-ya approved these changes Nov 15, 2025
View reviewed changes
Copy link
Member

@leona-ya leona-ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

electron_37, electron_38, electron_39 now build fine on x86_64-linux.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 15, 2025
@teutat3s
Copy link
Member Author

teutat3s commented Nov 15, 2025

electron_37, electron_38, electron_39 build fine on aarch64-linux.

@yuyuyureka yuyuyureka added this pull request to the merge queue Nov 15, 2025
Merged via the queue into NixOS:master with commit 97515e0 Nov 15, 2025
30 of 34 checks passed
@teutat3s teutat3s mentioned this pull request Nov 15, 2025
Merged
13 tasks
@teutat3s teutat3s added the 8.has: port to stable This PR already has a backport to the stable release. label Nov 15, 2025
@teutat3s teutat3s mentioned this pull request Nov 18, 2025
Merged
13 tasks
@teutat3s teutat3s deleted the electron-39-fix-build branch November 29, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leona-ya leona-ya leona-ya approved these changes

@yuyuyureka yuyuyureka yuyuyureka left review comments

@TomaSajt TomaSajt Awaiting requested review from TomaSajt

@yayayayaka yayayayaka Awaiting requested review from yayayayaka

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: electron_39

4 participants

@teutat3s @yayayayaka @yuyuyureka @leona-ya