Skip to content

multiviewer-for-f1: 2.1.0 -> 2.3.0#460768

Merged
gepbird merged 1 commit intoNixOS:masterfrom
linuxmobile:multiviewer
Dec 7, 2025
Merged

multiviewer-for-f1: 2.1.0 -> 2.3.0#460768
gepbird merged 1 commit intoNixOS:masterfrom
linuxmobile:multiviewer

Conversation

@linuxmobile
Copy link
Contributor

@linuxmobile linuxmobile commented Nov 11, 2025

Updated to latest version

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
    • [NixOS tests] in [nixos/tests].
    • [Package tests] at passthru.tests.
    • Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
  • Ran nixpkgs-review on this PR. See [nixpkgs-review usage].
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.

@nixpkgs-ci nixpkgs-ci bot requested a review from babeuh November 11, 2025 21:11
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 11, 2025
@linuxmobile
Copy link
Contributor Author

linuxmobile commented Nov 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 460768
Commit: f6b2e840627d231410de4c2fc2604100710964da

x86_64-linux

✅ 1 package built:
  • multiviewer-for-f1

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 11, 2025
matteo-pacini
matteo-pacini previously requested changes Nov 11, 2025
View reviewed changes
Copy link
Contributor

@matteo-pacini matteo-pacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs a bit of modernization

@linuxmobile
Copy link
Contributor Author

linuxmobile commented Nov 12, 2025 •
edited
Loading

LGTM, needs a bit of modernization

Stopping the flow of the PR by requesting changes that are not within the CONTRIBUTING section is completely unnecessary. If you believe the code can be improved, I recommend creating a new PR.

This topic was talked before here #400934

@gepbird gepbird added this pull request to the merge queue Dec 7, 2025
Merged via the queue into NixOS:master with commit 2281433 Dec 7, 2025
37 of 38 checks passed
@gepbird gepbird mentioned this pull request Dec 7, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matteo-pacini matteo-pacini Awaiting requested review from matteo-pacini

1 more reviewer

@babeuh babeuh babeuh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@linuxmobile @matteo-pacini @babeuh @gepbird