Skip to content

soundtracker: 1.0.5 -> 1.0.5.1, fix build, clean up#460605

Merged
Stunkymonkey merged 5 commits intoNixOS:masterfrom
LordGrimmauld:soundtracker-fix
Nov 12, 2025
Merged

soundtracker: 1.0.5 -> 1.0.5.1, fix build, clean up#460605
Stunkymonkey merged 5 commits intoNixOS:masterfrom
LordGrimmauld:soundtracker-fix

Conversation

@LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Nov 11, 2025 •
edited
Loading

Part of #457852
Found in #460292 (comment)

  • patched libxml2 configure logic
  • updated to 1.0.5.1
  • added pulse support
  • added strictDeps
  • removed with lib

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@LordGrimmauld LordGrimmauld added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 11, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Nov 11, 2025
@nixpkgs-ci nixpkgs-ci bot requested a review from fgaz November 11, 2025 08:49
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 11, 2025
@Stunkymonkey
Copy link
Contributor

Stunkymonkey commented Nov 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 460605
Commit: d0a81ec88869ea6026cfbf71debf9bc0ad03842b

x86_64-linux

✅ 1 package built:
  • soundtracker

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 11, 2025
@Stunkymonkey Stunkymonkey added this pull request to the merge queue Nov 12, 2025
Merged via the queue into NixOS:master with commit 5d1cb29 Nov 12, 2025
37 of 38 checks passed
LordGrimmauld
LordGrimmauld commented Nov 12, 2025
View reviewed changes
pkgs/by-name/so/soundtracker/package.nix
substituteInPlace configure.ac \
--replace-fail 'AM_PATH_XML2(2.6.0, [], AC_MSG_ERROR(Fatal error: Need libxml2 >= 2.6.0))' \
'PKG_CHECK_MODULES([XML], [libxml-2.0 >= 2.6.0])' \
--replace-fail 'XML_CPPFLAGS' 'XML_CFLAGS' \
Copy link
Contributor Author

@LordGrimmauld LordGrimmauld Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh crap i just realized this trailing \ shouldn't be here. Uh oh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stunkymonkey Stunkymonkey Stunkymonkey approved these changes

@fgaz fgaz Awaiting requested review from fgaz

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LordGrimmauld @Stunkymonkey