korrect: 0.2.1 -> 0.3.3

[dwt]

This release adds the ability to also get the correct version of the helm binary as well. Now both kubectl as well as helm use the version that is best suited for the cluster at hand, auto switching to the latest compatible release if available.

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[dwt]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 460269
Commit: 7c91e78bd671565d3342499f6cf2807fe956059d

---

x86_64-linux

❌ 1 package failed to build:

• korrect

---

aarch64-linux

✅ 1 package built:

• korrect

---

x86_64-darwin

✅ 1 package built:

• korrect

---

aarch64-darwin

✅ 1 package built:

• korrect

Not sure what's going on with the x86_64-linux build, manually building that with nix-build --attr korrect --eval-system x86_64-linux works fine.

[dwt]

The linux build fails with:

       Reason: builder failed with exit code 1.
       Output paths:
         /nix/store/n6gidz7rcxb7drwvhg4k2igfjhwd56d0-korrect-0.3.3-vendor
       Last 4 log lines:
       > Traceback (most recent call last):
       >   File "/nix/store/f2aiivbcplcfk3c30dmjgl0iw96yvwaz-fetch-cargo-vendor-util/bin/fetch-cargo-vendor-util", line 16, in <module>
       >     import requests
       > ModuleNotFoundError: No module named 'requests'

Which seems to me to mean that it's somehow a nix tooling problem.

[dwt]

After a rebase I can now reproduce this outside of nixpkgs-reveiw, I'll investigate and file bugs. I'm still pretty confident that this is an upstream problem and not a fault of this PR.

[dwt]

see #461884 for debugging of the build failure

[eclairevoyant]

Approved automatically following the successful run of nixpkgs-review.

[eclairevoyant]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 460269
Commit: a40339417f4b61af54d166cfa142b97d9b44d8aa

---

x86_64-linux

✅ 1 package built:

• korrect

[dwt]

@eclairevoyant Ok, so it's pretty likely that this is an issue with my rosetta based linux builder. Thanks!

[dwt]

yes, that linux builder was the reason, see fix at #463106

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2660