Conversation
|
I find it hard to judge whether to merge this patch or not because there is no description of what it does. I'm no VM expert, though, so maybe others don't have that problem. Also, it's not clear to me how the change to |
(Hmh. Apparently, github changes existing pull requests after the fact. That wasn't at all clear. So I am supposed to freeze a branch while a pull request is active? That seems quite silly...) |
|
@mornfall You can change the commit range for a pull request, I think. |
|
mornfall, how do you plan to proceed with this request? As it is now, it contains seemingly unrelated patches to Haskell packages. |
|
I committed some of your patches manually (i.e. the RPM update and the refactoring). Could you please merge the current |
|
Rebased. I use this branch to feed a Hydra instance somewhere, and I don't feel like maintaining multiple branches. Please cherry-pick at will, I'll rebase this from time to time. Maybe the pull request should be closed though? I have no idea what the best procedure is. Apparently, pull requests update themselves when I push to my branch, which is something that probably makes them awkward for this use. |
|
Mornfall, I'm not sure what to do about this request. I have committed some of your changes, and they ended up breaking other builds. On that occasion, I would have expected you to step up and make an effort to fix those errors, but nothing happened, so the commits had to be revoked. Given these circumstances, I don't want to commit any further patches unless I can personally maintain them. That is not the case for the patches in this pull request, so I will not commit them. Maybe someone else will, but so far it doesn't look like it. |
|
@mornfall I'm closing this PR. If you have specific changes you want merged in, please put them in a separate branch explicitly for merging. |
|
Well, if someone told me that these patches broke something, I'd have tried to fix that at least. But with the amount of paperwork that goes with anything around here... I guess I'll just maintain a fork. You know, github won't tell me that something got merged, and I don't have time to monitor each patch going into nixpkgs to check if it wasn't something from my branch and if it was whether it broke anything. If you have a list of things that are likely to break when I work on build-support/vm, give me a list and I can add those things to my own hydra (http://anna2.fi.muni.cz:3000 these days). I'll try to keep everything in working order. |
Fixes: 12/151 Test NixOS#46: jpegtran-shared-icc ...............................***Failed 0.03 sec Premature end of JPEG file JPEG datastream contains no image 63/151 Test NixOS#47: jpegtran-shared-icc-cmp ...........................***Failed 0.12 sec Could not obtain MD5 sum: No such file or directory The following tests FAILED: 46 - jpegtran-shared-icc (Failed) 47 - jpegtran-shared-icc-cmp (Failed) Example build: https://hydra.nixos.org/build/117594627
RFC NixOS#112 raised the question of what the source of truth is about the platforms supported in Nixpkgs. RFC NixOS#46 specified the authoritative source would be the Nixpkgs manual but this hasn't happened yet. When it comes to Nixpkgs the tier list is currently only important to determine what platforms Hydra should evaluate for. This information is currently in `lib/systems/flake-systems.nix`. However, a manual section as described in RFC NixOS#46 would be a second consumer, so a separate file is warranted. We re-introduce `lib/systems/supported.nix` as a suitable authoritative source. A Nixpkgs manual section could be auto-generated based on this file.
`lib.systems.supported` is intended to be the authoritative source on what support tier platforms belong to. By getting the platforms built by Hydra from there we make explicit which platforms are currently not supported according to their tier and should either be taken care of or reassigned to a different tier. `x86_64-unknown-linux-musl` is listed in RFC NixOS#46 as a tier 3 platform but is not currently built by Hydra for example. And many platforms originally proposed as tier 7 are in fact built by Hydra and at least some of them should be considered for promotion.
fix(mount): EFI umask
Update batch page for latest updates.
No description provided.