Skip to content

Comments

build-support/release changes#46

Closed
mornfall wants to merge 5 commits intoNixOS:masterfrom
mornfall:master
Closed

build-support/release changes#46
mornfall wants to merge 5 commits intoNixOS:masterfrom
mornfall:master

Conversation

@mornfall
Copy link

No description provided.

@peti
Copy link
Member

peti commented Jul 16, 2012

I find it hard to judge whether to merge this patch or not because there is no description of what it does. I'm no VM expert, though, so maybe others don't have that problem.

Also, it's not clear to me how the change to haskell-defaults.nix fits in with the rest of the patches.

@mornfall
Copy link
Author

  1. haskell-defaults are not part of this request
  2. the commits have comments and should be reasonably obvious

(Hmh. Apparently, github changes existing pull requests after the fact. That wasn't at all clear. So I am supposed to freeze a branch while a pull request is active? That seems quite silly...)

@shlevy
Copy link
Member

shlevy commented Jul 17, 2012

@mornfall You can change the commit range for a pull request, I think.

@peti
Copy link
Member

peti commented Jul 23, 2012

mornfall, how do you plan to proceed with this request? As it is now, it contains seemingly unrelated patches to Haskell packages.

@peti
Copy link
Member

peti commented Jul 23, 2012

I committed some of your patches manually (i.e. the RPM update and the refactoring). Could you please merge the current master branch into your forked copy (or even better; rebase your forked copy relative to the current master from the upstream repository) and push the result to update this pull request, please?

@mornfall
Copy link
Author

Rebased. I use this branch to feed a Hydra instance somewhere, and I don't feel like maintaining multiple branches. Please cherry-pick at will, I'll rebase this from time to time. Maybe the pull request should be closed though? I have no idea what the best procedure is. Apparently, pull requests update themselves when I push to my branch, which is something that probably makes them awkward for this use.

@peti
Copy link
Member

peti commented Aug 1, 2012

Mornfall, I'm not sure what to do about this request. I have committed some of your changes, and they ended up breaking other builds. On that occasion, I would have expected you to step up and make an effort to fix those errors, but nothing happened, so the commits had to be revoked. Given these circumstances, I don't want to commit any further patches unless I can personally maintain them. That is not the case for the patches in this pull request, so I will not commit them. Maybe someone else will, but so far it doesn't look like it.

@shlevy
Copy link
Member

shlevy commented Aug 2, 2012

@mornfall I'm closing this PR. If you have specific changes you want merged in, please put them in a separate branch explicitly for merging.

@shlevy shlevy closed this Aug 2, 2012
@mornfall
Copy link
Author

mornfall commented Aug 2, 2012

Well, if someone told me that these patches broke something, I'd have tried to fix that at least. But with the amount of paperwork that goes with anything around here... I guess I'll just maintain a fork. You know, github won't tell me that something got merged, and I don't have time to monitor each patch going into nixpkgs to check if it wasn't something from my branch and if it was whether it broke anything. If you have a list of things that are likely to break when I work on build-support/vm, give me a list and I can add those things to my own hydra (http://anna2.fi.muni.cz:3000 these days). I'll try to keep everything in working order.

danielfullmer added a commit to danielfullmer/nixpkgs that referenced this pull request Aug 12, 2017
This includes the patches from the pull requests NixOS#42, NixOS#43, and NixOS#46
submitted to Grawp/rtl8812au_rtl8821au
thefloweringash added a commit to thefloweringash/nixpkgs that referenced this pull request May 5, 2020
Fixes:

12/151 Test  NixOS#46: jpegtran-shared-icc ...............................***Failed    0.03 sec
Premature end of JPEG file
JPEG datastream contains no image

63/151 Test  NixOS#47: jpegtran-shared-icc-cmp ...........................***Failed    0.12 sec
Could not obtain MD5 sum: No such file or directory

The following tests FAILED:
         46 - jpegtran-shared-icc (Failed)
         47 - jpegtran-shared-icc-cmp (Failed)

Example build: https://hydra.nixos.org/build/117594627
Profpatsch pushed a commit that referenced this pull request Jun 20, 2020
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
toonn added a commit to toonn/nixpkgs that referenced this pull request Jul 22, 2023
RFC NixOS#112 raised the question of what the source of truth is about the
platforms supported in Nixpkgs. RFC NixOS#46 specified the authoritative
source would be the Nixpkgs manual but this hasn't happened yet.

When it comes to Nixpkgs the tier list is currently only important to
determine what platforms Hydra should evaluate for. This information is
currently in `lib/systems/flake-systems.nix`. However, a manual section
as described in RFC NixOS#46 would be a second consumer, so a separate file
is warranted.

We re-introduce `lib/systems/supported.nix` as a suitable authoritative
source. A Nixpkgs manual section could be auto-generated based on this
file.
toonn added a commit to toonn/nixpkgs that referenced this pull request Jul 22, 2023
`lib.systems.supported` is intended to be the authoritative source on
what support tier platforms belong to. By getting the platforms built by
Hydra from there we make explicit which platforms are currently not
supported according to their tier and should either be taken care of or
reassigned to a different tier.

`x86_64-unknown-linux-musl` is listed in RFC NixOS#46 as a tier 3 platform
but is not currently built by Hydra for example. And many platforms
originally proposed as tier 7 are in fact built by Hydra and at least
some of them should be considered for promotion.
Hyphastorm pushed a commit to Hyphastorm/nixpkgs that referenced this pull request Apr 1, 2025
K900 pushed a commit to K900/nixpkgs that referenced this pull request Aug 7, 2025
notklea pushed a commit to notklea/nixpkgs that referenced this pull request Dec 1, 2025
Update batch page for latest updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants