Skip to content

Comments

nixosTests.agda.base: fix build#459767

Merged
ncfavier merged 1 commit intoNixOS:masterfrom
quantenzitrone:nixosTests.agda
Nov 8, 2025
Merged

nixosTests.agda.base: fix build#459767
ncfavier merged 1 commit intoNixOS:masterfrom
quantenzitrone:nixosTests.agda

Conversation

@quantenzitrone
Copy link
Contributor

@quantenzitrone quantenzitrone commented Nov 8, 2025

the binary adga-mode has been deprecated
one is supposed to use the main binary with --emacs-mode instead

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@quantenzitrone
nixosTests.agda.base: fix build
4947d15 
the binary adga-mode has been deprecated
one is supposed to use the main binary with --emacs-mode instead
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Nov 8, 2025
ncfavier
ncfavier approved these changes Nov 8, 2025
View reviewed changes
Copy link
Member

@ncfavier ncfavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see I merged #452961 too fast...

@ncfavier ncfavier added this pull request to the merge queue Nov 8, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 8, 2025
Merged via the queue into NixOS:master with commit 16ac6b8 Nov 8, 2025
32 of 34 checks passed
@quantenzitrone quantenzitrone deleted the nixosTests.agda branch November 8, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncfavier ncfavier ncfavier approved these changes

@alexarice alexarice Awaiting requested review from alexarice

@phijor phijor Awaiting requested review from phijor

@turion turion Awaiting requested review from turion

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quantenzitrone @ncfavier