Skip to content

[Backport release-25.05] lib.extendMkDerivation: improve argument documentation#459209

Merged
MattSturgeon merged 3 commits intoNixOS:release-25.05from
ShamrockLee:backport-25.05-lib-extendMkDerivation-doc-misc
Nov 6, 2025
Merged

[Backport release-25.05] lib.extendMkDerivation: improve argument documentation#459209
MattSturgeon merged 3 commits intoNixOS:release-25.05from
ShamrockLee:backport-25.05-lib-extendMkDerivation-doc-misc

Conversation

@ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Nov 6, 2025

This PR backports part of #459124 which improves the documentation of its arguments.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ShamrockLee ShamrockLee added the 4.workflow: backport This targets a stable branch label Nov 6, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: lib The Nixpkgs function library labels Nov 6, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 6, 2025
MattSturgeon
MattSturgeon approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Why's this a draft?

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 6, 2025
@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Nov 6, 2025

I was waiting for the CI.

@ShamrockLee ShamrockLee marked this pull request as ready for review November 6, 2025 18:36
@MattSturgeon MattSturgeon added this pull request to the merge queue Nov 6, 2025
Merged via the queue into NixOS:release-25.05 with commit 5f7aa4d Nov 6, 2025
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philiptaron philiptaron philiptaron approved these changes

@MattSturgeon MattSturgeon MattSturgeon approved these changes

Assignees

No one assigned

Labels

4.workflow: backport This targets a stable branch 6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShamrockLee @philiptaron @MattSturgeon