Skip to content

ucx: Add cuda_nvcc to buildDeps if building with cuda.#459164

Closed
sliedes wants to merge 1 commit intoNixOS:masterfrom
sliedes:ucx-cuda-deps
Closed

ucx: Add cuda_nvcc to buildDeps if building with cuda.#459164
sliedes wants to merge 1 commit intoNixOS:masterfrom
sliedes:ucx-cuda-deps

Conversation

@sliedes
Copy link
Contributor

@sliedes sliedes commented Nov 6, 2025

This is necessitated by the change made in #457424.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot requested a review from markuskowa November 6, 2025 15:10
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! labels Nov 6, 2025
@sliedes
Copy link
Contributor Author

sliedes commented Nov 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 459164
Commit: f8e94b87828a5874fa1f0be9f33df6cf3c3a9df7

@sliedes
Copy link
Contributor Author

sliedes commented Nov 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 459164 --extra-nixpkgs-config '{ allowUnfree = true; cudaSupport = true; }' --package ucc
Commit: f8e94b87828a5874fa1f0be9f33df6cf3c3a9df7


x86_64-linux

✅ 2 packages built:
  • ucc
  • ucc.dev (ucc.dev.dev)

@ConnorBaker ConnorBaker added the 6.topic: cuda Parallel computing platform and API label Nov 7, 2025
@ConnorBaker ConnorBaker self-requested a review November 7, 2025 22:28
@ConnorBaker ConnorBaker self-assigned this Nov 7, 2025
@ConnorBaker ConnorBaker moved this from New to 🏗 In progress in CUDA Team Nov 7, 2025
@ConnorBaker
Copy link
Contributor

Instead of adding it to buildInputs, would you mind changing the line in configureFlags to

++ lib.optionals enableCuda [ "--with-cuda=${cudaPackages.cuda_nvcc}" ]

other than that, looks good!

This is necessitated by the change made in NixOS#457424.
@sliedes
Copy link
Contributor Author

sliedes commented Nov 8, 2025

Instead of adding it to buildInputs, would you mind changing the line in configureFlags to

++ lib.optionals enableCuda [ "--with-cuda=${cudaPackages.cuda_nvcc}" ]

other than that, looks good!

I also removed it from nativeBuildInputs. Maybe that's correct? :P

@sliedes
Copy link
Contributor Author

sliedes commented Nov 8, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 459164 --extra-nixpkgs-config '{ allowUnfree = true; cudaSupport = true; }' --package ucx
Commit: 83cb192d8ff248930dc5666067403f9c9ee1d80d


x86_64-linux

✅ 3 packages built:
  • ucx
  • ucx.dev (ucx.dev.dev, ucx.dev.doc)
  • ucx.doc (ucx.doc.dev, ucx.doc.doc)

@nixpkgs-ci nixpkgs-ci bot removed the 6.topic: cuda Parallel computing platform and API label Nov 8, 2025
@sliedes
Copy link
Contributor Author

sliedes commented Nov 8, 2025

Also trying to run nixpkgs-review pr 459164 --extra-nixpkgs-config '{ allowUnfree = true; cudaSupport = true; }', but that somehow tries to build cuda12.8-cuda_compat-12.8.39468522, which fails because this is x86:

┃ error: Cannot build '/nix/store/r7sgq2qvkhc89dfhnf6ak5kp2cbirzkm-cuda12.8-cuda_compat-12.8.39468522.drv'.
┃        Reason: builder failed with exit code 1.
┃        Output paths:
┃          /nix/store/6lnv84qhzjsdyiqli7wdw5a6v5fl108d-cuda12.8-cuda_compat-12.8.39468522
┃        Last 15 log lines:
┃        > structuredAttrs is enabled
┃        > source: sourcing buildRedistHook.bash (hostOffset=-1) (targetOffset=0)
┃        > buildRedistHookRegistration: added unpackCudaLibSubdir to postUnpackHooks
┃        > buildRedistHookRegistration: added unpackCudaPkgConfigDirs to postUnpackHooks
┃        > buildRedistHookRegistration: added patchCudaPkgConfig to prePatchHooks
┃        > buildRedistHookRegistration: added checkCudaFhsRefs to postInstallCheckHooks
┃        > buildRedistHookRegistration: added checkCudaNonEmptyOutputs to postInstallCheckHooks
┃        > buildRedistHookRegistration: added fixupPropagatedBuildOutputsForMultipleOutputs to preFixupHooks
┃        > buildRedistHookRegistration: added fixupCudaPropagatedBuildOutputsToOut to postFixupHooks
┃        > Sourcing auto-add-driver-runpath-hook
┃        > Using autoAddDriverRunpath
┃        > Sourcing fix-elf-files.sh
┃        > Sourcing mark-for-cudatoolkit-root-hook
┃        > Running phase: unpackPhase
┃        > variable $src or $srcs should point to the source
┃        For full logs, run:
┃          nix log /nix/store/r7sgq2qvkhc89dfhnf6ak5kp2cbirzkm-cuda12.8-cuda_compat-12.8.39468522.drv

@sliedes
Copy link
Contributor Author

sliedes commented Nov 8, 2025

Also, why did this happen? Was it somehow triggered by my force push? 🤯

@nixpkgs-ci nixpkgs-ci bot removed the 6.topic: cuda label 14 minutes ago

@ConnorBaker ConnorBaker mentioned this pull request Nov 10, 2025
13 tasks
@ConnorBaker
Copy link
Contributor

Superceded by #459164.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in CUDA Team Nov 10, 2025
@sliedes sliedes deleted the ucx-cuda-deps branch November 11, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants