-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
lib.extendMkDerivation: add argument excludeFunctionArgNames and improve argument documentation #459124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
philiptaron
merged 4 commits into
NixOS:master
from
ShamrockLee:lib-extendMkDerivation-exclude-function-args
Nov 6, 2025
Merged
lib.extendMkDerivation: add argument excludeFunctionArgNames and improve argument documentation #459124
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
918e017
lib.extendMkDerivation: adjust default value documentation
ShamrockLee 7f6ce90
lib.extendMkDerivation: fix argument documentation layout
ShamrockLee d75b203
lib.extendMkDerivation: document the typical usage of inheritFunction…
ShamrockLee 3026703
lib.extendMkDerivation: add argument excludeFunctionArgNames
ShamrockLee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The semantics here, as I understand them:
inheritFunctionArgsis set totrue(the default)a. Whatever the arguments are to
constructDrvwill be usedb. Except for those listed in
excludeDrvArgNames, which will be excluded.So if
constructDrvhad an argument without a default, but the derived build helper had a default, the result would have a default.excludeFunctionArgNameslist, it will be removed from the function arguments list.I like those semantics.