Skip to content

doctest: disable tests on isStatic platforms#458967

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
trofi:toml11-fix-isStatic
Nov 7, 2025
Merged

doctest: disable tests on isStatic platforms#458967
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
trofi:toml11-fix-isStatic

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Nov 5, 2025

Without the change doctest can't be built as
https://hydra.nixos.org/build/311427996:

[ 80%] Linking CXX shared library libimplementation.so
ld: crtbeginT.o: relocation R_X86_64_32 against hidden symbol `__TMC_END__' can not be used when making a shared object
ld: failed to set dynamic section sizes: bad value
collect2: error: ld returned 1 exit status

Thus is fail nixStatic and lixStatic packages
in master. Let's disable tests that require
stared libraries.

ZHF: #457852

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from Chaostheorie November 5, 2025 22:34
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Nov 5, 2025
@trofi trofi marked this pull request as draft November 5, 2025 22:39
@trofi
Copy link
Contributor Author

trofi commented Nov 5, 2025

Actually, another option is to disable tests on doctest package. Let me try that one instead.

Without the change `doctest` can't be built as
https://hydra.nixos.org/build/311427996:

    [ 80%] Linking CXX shared library libimplementation.so
    ld: crtbeginT.o: relocation R_X86_64_32 against hidden symbol `__TMC_END__' can not be used when making a shared object
    ld: failed to set dynamic section sizes: bad value
    collect2: error: ld returned 1 exit status

Thus is fail `nixStatic` and `lixStatic` packages
in `master`. Let's disable tests that require
stared libraries.

ZHF: NixOS#457852
@trofi trofi force-pushed the toml11-fix-isStatic branch from ccee396 to bc905df Compare November 5, 2025 22:44
@trofi trofi changed the title toml11: disable tests on isStatic platforms doctest: disable tests on isStatic platforms Nov 5, 2025
@trofi
Copy link
Contributor Author

trofi commented Nov 5, 2025

Moved disabled tests to doctest instead. Ready for review.

@trofi trofi marked this pull request as ready for review November 5, 2025 22:45
@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Nov 7, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 7, 2025
Merged via the queue into NixOS:master with commit e1f20ee Nov 7, 2025
33 of 35 checks passed
@trofi trofi deleted the toml11-fix-isStatic branch November 7, 2025 20:18
@alois31 alois31 mentioned this pull request Nov 8, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants