doctest: disable tests on isStatic platforms#458967
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Nov 7, 2025
Merged
doctest: disable tests on isStatic platforms#458967SuperSandro2000 merged 1 commit intoNixOS:masterfrom
isStatic platforms#458967SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Conversation
13 tasks
Contributor
Author
|
Actually, another option is to disable tests on |
Without the change `doctest` can't be built as https://hydra.nixos.org/build/311427996: [ 80%] Linking CXX shared library libimplementation.so ld: crtbeginT.o: relocation R_X86_64_32 against hidden symbol `__TMC_END__' can not be used when making a shared object ld: failed to set dynamic section sizes: bad value collect2: error: ld returned 1 exit status Thus is fail `nixStatic` and `lixStatic` packages in `master`. Let's disable tests that require stared libraries. ZHF: NixOS#457852
ccee396 to
bc905df
Compare
isStatic platformsisStatic platforms
Contributor
Author
|
Moved disabled tests to |
SuperSandro2000
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change
doctestcan't be built ashttps://hydra.nixos.org/build/311427996:
Thus is fail
nixStaticandlixStaticpackagesin
master. Let's disable tests that requirestared libraries.
ZHF: #457852
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.